mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 18:47:34 +00:00
LibCore+Everywhere: Make Core::Stream::read() return Bytes
A mistake I've repeatedly made is along these lines: ```c++ auto nread = TRY(source_file->read(buffer)); TRY(destination_file->write(buffer)); ``` It's a little clunky to have to create a Bytes or StringView from the buffer's data pointer and the nread, and easy to forget and just use the buffer. So, this patch changes the read() function to return a Bytes of the data that were just read. The other read_foo() methods will be modified in the same way in subsequent commits. Fixes #13687
This commit is contained in:
parent
6654efcd82
commit
3b1e063d30
22 changed files with 103 additions and 103 deletions
|
@ -51,10 +51,10 @@ void Request::stream_into_impl(T& stream)
|
|||
break;
|
||||
if (result.is_error())
|
||||
continue;
|
||||
auto nread = result.value();
|
||||
if (nread == 0)
|
||||
auto read_bytes = result.release_value();
|
||||
if (read_bytes.is_empty())
|
||||
break;
|
||||
if (!stream.write_or_error({ buf, nread })) {
|
||||
if (!stream.write_or_error(read_bytes)) {
|
||||
// FIXME: What do we do here?
|
||||
TODO();
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue