RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:57:44 +00:00
Code Issues Activity Actions

LibJS: Put exports before symbols in keys of module namespace object

Browse source
This commit is contained in:
davidot 2022-08-31 20:31:02 +02:00 • committed by Linus Groh
parent fb61e9274a
commit 3b56043612
3 changed files with 27 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Tests/modules/basic-modules.js
View file

@ -182,6 +182,10 @@ describe("in- and exports", () => {
test("can import with (useless) assertions", () => {
expectModulePassed("./import-with-assertions.mjs");
});
test("namespace has expected ordering", () => {
expectModulePassed("./namespace-order.mjs");
});
});
describe("loops", () => {

16
Userland/Libraries/LibJS/Tests/modules/namespace-order.mjs Normal file
View file

@ -0,0 +1,16 @@
import * as ns from "./default-and-star-export.mjs";
const keys = Reflect.ownKeys(ns);
// The keys should be in alphabetical order and @@toString at the end
if (keys.length < 4) throw new Error("Expected at least 3 keys and @@toStringTag");
if (keys[0] !== "") throw new Error('Expected keys[0] === ""');
if (keys[1] !== "*") throw new Error('Expected keys[1] === "*"');
if (keys[2] !== "default") throw new Error('Expected keys[2] === "default"');
if (keys.indexOf(Symbol.toStringTag) <= 2)
throw new Error("Expected Symbol.toStringTag to be behind string keys");
export const passed = true;