RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:17:34 +00:00
Code Issues Activity Actions

LibWeb: Add the missing CustomEvent IDL constructor

Browse source
This commit is contained in:
Idan Horowitz 2021-09-29 20:32:29 +03:00 • committed by Andreas Kling
parent e04f3c713c
commit 3b9e8ec597
3 changed files with 28 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/DOM/CustomEvent.cpp
View file

@ -8,15 +8,6 @@
namespace Web::DOM { namespace Web::DOM {
CustomEvent::CustomEvent(FlyString const& event_name)
: Event(event_name)
{
}
CustomEvent::~CustomEvent()
{
}
void CustomEvent::visit_edges(JS::Cell::Visitor& visitor) void CustomEvent::visit_edges(JS::Cell::Visitor& visitor)
{ {
visitor.visit(m_detail); visitor.visit(m_detail);

25
Userland/Libraries/LibWeb/DOM/CustomEvent.h
View file

@ -10,17 +10,25 @@
namespace Web::DOM { namespace Web::DOM {
struct CustomEventInit : public EventInit {
JS::Value detail { JS::js_null() };
};
// https://dom.spec.whatwg.org/#customevent // https://dom.spec.whatwg.org/#customevent
class CustomEvent : public Event { class CustomEvent : public Event {
public: public:
using WrapperType = Bindings::CustomEventWrapper; using WrapperType = Bindings::CustomEventWrapper;
static NonnullRefPtr<CustomEvent> create(FlyString const& event_name) static NonnullRefPtr<CustomEvent> create(FlyString const& event_name, CustomEventInit const& event_init = {})
{ {
return adopt_ref(*new CustomEvent(event_name)); return adopt_ref(*new CustomEvent(event_name, event_init));
}
static NonnullRefPtr<CustomEvent> create_with_global_object(Bindings::WindowObject&, const FlyString& event_name, CustomEventInit const& event_init)
{
return CustomEvent::create(event_name, event_init);
} }
virtual ~CustomEvent() override; virtual ~CustomEvent() override = default;
// https://dom.spec.whatwg.org/#dom-customevent-detail // https://dom.spec.whatwg.org/#dom-customevent-detail
JS::Value detail() const { return m_detail; } JS::Value detail() const { return m_detail; }
@ -30,7 +38,16 @@ public:
void init_custom_event(String const& type, bool bubbles, bool cancelable, JS::Value detail); void init_custom_event(String const& type, bool bubbles, bool cancelable, JS::Value detail);
private: private:
CustomEvent(FlyString const&); explicit CustomEvent(FlyString const& event_name)
: Event(event_name)
{
}
CustomEvent(FlyString const& event_name, CustomEventInit const& event_init)
: Event(event_name, event_init)
, m_detail(event_init.detail)
{
}
// https://dom.spec.whatwg.org/#dom-customevent-initcustomevent-type-bubbles-cancelable-detail-detail // https://dom.spec.whatwg.org/#dom-customevent-initcustomevent-type-bubbles-cancelable-detail-detail
JS::Value m_detail { JS::js_null() }; JS::Value m_detail { JS::js_null() };

8
Userland/Libraries/LibWeb/DOM/CustomEvent.idl
View file

@ -1,8 +1,14 @@
#import <Event.idl>
[Exposed=(Window,Worker), CustomVisit] [Exposed=(Window,Worker), CustomVisit]
interface CustomEvent : Event { interface CustomEvent : Event {
// FIXME: constructor(DOMString type, optional CustomEventInit eventInitDict = {}); constructor(DOMString type, optional CustomEventInit eventInitDict = {});
readonly attribute any detail; readonly attribute any detail;
undefined initCustomEvent(DOMString type, optional boolean bubbles = false, optional boolean cancelable = false, optional any detail = null); undefined initCustomEvent(DOMString type, optional boolean bubbles = false, optional boolean cancelable = false, optional any detail = null);
}; };
dictionary CustomEventInit : EventInit {
any detail = null;
};