RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:48:11 +00:00
Code Issues Activity Actions

LibWeb: Make FormAssociatedElement inherit from HTMLElement

Browse source 
The new event target implementation requires us to downcast an
EventTarget to a FormAssociatedElement to check if the current Element
EventTarget has a form owner to setup a with scope for the form owner.

This also makes all form associated elements inherit from
FormAssociatedElement where it was previously missing.

https://html.spec.whatwg.org/#form-associated-element
This commit is contained in:
Luke Wilde 2021-10-14 16:18:49 +01:00 • committed by Linus Groh
parent f71f404e0c
commit 3bb5c6207f
18 changed files with 31 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/HTML/HTMLSelectElement.h
View file

@ -12,9 +12,7 @@
namespace Web::HTML {
class HTMLSelectElement final
: public HTMLElement
, public FormAssociatedElement {
class HTMLSelectElement final : public FormAssociatedElement {
public:
using WrapperType = Bindings::HTMLSelectElementWrapper;
@ -25,9 +23,6 @@ private:
// ^DOM::Node
virtual void inserted() override;
virtual void removed_from(DOM::Node*) override;
// ^HTML::FormAssociatedElement
virtual HTMLElement& form_associated_element_to_html_element() override { return *this; }
};
}