RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 19:35:08 +00:00
Code Issues Activity Actions

LibHTML: Templatize Node::first_child_of_type<T>()

Browse source 
This is a lot nicer than first_child_with_tag_name(...).

The is<T>(Node) functions are obviously unoptimized at the moment,
and this is about establishing pleasant patterns right now. :^)
This commit is contained in:
Andreas Kling 2019-10-06 20:47:57 +02:00
parent f52f2736e1
commit 3bee9d3d3c
5 changed files with 48 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibHTML/DOM/Document.cpp
View file

@ -41,7 +41,7 @@ void Document::normalize()
const HTMLHtmlElement* Document::document_element() const
{
return static_cast<const HTMLHtmlElement*>(first_child_with_tag_name("html"));
return first_child_of_type<HTMLHtmlElement>();
}
const HTMLHeadElement* Document::head() const
@ -49,7 +49,7 @@ const HTMLHeadElement* Document::head() const
auto* html = document_element();
if (!html)
return nullptr;
return static_cast<const HTMLHeadElement*>(html->first_child_with_tag_name("head"));
return html->first_child_of_type<HTMLHeadElement>();
}
const HTMLBodyElement* Document::body() const
@ -57,7 +57,7 @@ const HTMLBodyElement* Document::body() const
auto* html = document_element();
if (!html)
return nullptr;
return static_cast<const HTMLBodyElement*>(html->first_child_with_tag_name("body"));
return html->first_child_of_type<HTMLBodyElement>();
}
String Document::title() const
@ -66,7 +66,7 @@ String Document::title() const
if (!head_element)
return {};
auto* title_element = static_cast<const HTMLTitleElement*>(head_element->first_child_with_tag_name("title"));
auto* title_element = head_element->first_child_of_type<HTMLTitleElement>();
if (!title_element)
return {};