RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-25 19:15:06 +00:00
Code Issues Activity Actions

LibWeb: Declare optional parse results inlined in if statements

Browse source
This commit is contained in:
Bastiaan van der Plaat 2023-12-07 18:40:54 +01:00 • committed by Tim Flynn
parent 1b9a961fb0
commit 3bfc2f5e95
5 changed files with 40 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Userland/Libraries/LibWeb/HTML/HTMLProgressElement.cpp
View file

@ -37,13 +37,11 @@ void HTMLProgressElement::visit_edges(Cell::Visitor& visitor)
// https://html.spec.whatwg.org/multipage/form-elements.html#dom-progress-value
double HTMLProgressElement::value() const
{
auto maybe_value_string = get_attribute(HTML::AttributeNames::value);
if (!maybe_value_string.has_value())
return 0;
auto maybe_value = parse_floating_point_number(maybe_value_string.value());
if (!maybe_value.has_value())
return 0;
return clamp(maybe_value.value(), 0, max());
if (auto value_string = get_attribute(HTML::AttributeNames::value); value_string.has_value()) {
if (auto value = parse_floating_point_number(*value_string); value.has_value())
return clamp(*value, 0, max());
}
return 0;
}
WebIDL::ExceptionOr<void> HTMLProgressElement::set_value(double value)
@ -60,13 +58,11 @@ WebIDL::ExceptionOr<void> HTMLProgressElement::set_value(double value)
// https://html.spec.whatwg.org/multipage/form-elements.html#dom-progress-max
double HTMLProgressElement::max() const
{
auto maybe_max_string = get_attribute(HTML::AttributeNames::max);
if (!maybe_max_string.has_value())
return 1;
auto maybe_max = parse_floating_point_number(maybe_max_string.value());
if (!maybe_max.has_value())
return 1;
return AK::max(maybe_max.value(), 0);
if (auto max_string = get_attribute(HTML::AttributeNames::max); max_string.has_value()) {
if (auto max = parse_floating_point_number(*max_string); max.has_value())
return AK::max(*max, 0);
}
return 1;
}
WebIDL::ExceptionOr<void> HTMLProgressElement::set_max(double value)