RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 08:54:58 +00:00
Code Issues Activity Actions

Userland+Ladybird: Always specify url to be about:srcdoc in load_html()

Browse source 
After moving to navigables, we started reusing the code that populates
session history entries with the srcdoc attribute value from iframes
in `Page::load_html()` for loading HTML.

This change addresses a crash in `determine_the_origin` which occurred
because this method expected the URL to be `about:srcdoc` if we also
provided HTML content (previously, it was the URL passed along with the
HTML content into `load_html()`).
This commit is contained in:
Aliaksandr Kalenik 2023-09-17 17:12:17 +02:00 • committed by Andreas Kling
parent 8e832a174e
commit 3c675e3f25
18 changed files with 31 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Ladybird/Qt/Tab.cpp
View file

@ -217,7 +217,7 @@ Tab::Tab(BrowserWindow* window, StringView webdriver_content_ipc_path, WebView::
view().on_received_source = [this](auto const& url, auto const& source) {
auto html = WebView::highlight_source(url, source);
m_window->new_tab(html, url, Web::HTML::ActivateTab::Yes);
m_window->new_tab(html, Web::HTML::ActivateTab::Yes);
};
view().on_navigate_back = [this]() {
@ -550,9 +550,9 @@ void Tab::navigate(QString url_qstring)
view().load(url_string);
}
void Tab::load_html(StringView html, URL const& url)
void Tab::load_html(StringView html)
{
view().load_html(html, url);
view().load_html(html);
}
void Tab::back()