RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:48:11 +00:00
Code Issues Activity Actions

LibWeb: Use min-height in calculating block box height

Browse source 
Now we use min-height for calculating the height of block boxes.
Besides, now we check if min-height/max-height are percentage values
and don't use them if parent's height isn't explicitly set (CSS 2.1
section 10.7).
This commit is contained in:
Egor Ananyin 2021-04-29 18:20:56 +03:00 • committed by Andreas Kling
parent 5ae2774018
commit 3ca6d7dd36
1 changed files with 12 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

27
Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -314,26 +314,23 @@ void BlockFormattingContext::compute_height(Box& box)
if (is<ReplacedBox>(box)) {
height = compute_height_for_replaced_element(downcast<ReplacedBox>(box));
} else {
if (box.computed_values().height().is_undefined_or_auto()) {
if (box.computed_values().height().is_undefined_or_auto()
|| (computed_values.height().is_percentage() && !containing_block.computed_values().height().is_absolute())) {
height = compute_auto_height_for_block_level_element(box);
} else {
CSS::Length specified_height;
if (computed_values.height().is_percentage() && !containing_block.computed_values().height().is_absolute()) {
specified_height = CSS::Length::make_auto();
} else {
specified_height = computed_values.height().resolved_or_auto(box, containing_block.height());
}
auto specified_max_height = computed_values.max_height().resolved_or_auto(box, containing_block.height());
if (!specified_height.is_auto()) {
float used_height = specified_height.to_px(box);
if (!specified_max_height.is_auto())
used_height = min(used_height, specified_max_height.to_px(box));
height = used_height;
}
height = computed_values.height().resolved_or_auto(box, containing_block.height()).to_px(box);
}
}
auto specified_max_height = computed_values.max_height().resolved_or_auto(box, containing_block.height());
if (!specified_max_height.is_auto()
&& !(computed_values.max_height().is_percentage() && !containing_block.computed_values().height().is_absolute()))
height = min(height, specified_max_height.to_px(box));
auto specified_min_height = computed_values.min_height().resolved_or_auto(box, containing_block.height());
if (!specified_min_height.is_auto()
&& !(computed_values.min_height().is_percentage() && !containing_block.computed_values().height().is_absolute()))
height = max(height, specified_min_height.to_px(box));
box.set_height(height);
}