From 3cc5286565721335e72dc92fd688a85505ef2568 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Wed, 14 Apr 2021 10:34:18 -0400 Subject: [PATCH] LibWeb: Helper for creating load requests with a Cookie header Instead of all interested parties needing to write out the code to get the cookie value for a load request, add a static helper to do it in one location. --- Userland/Libraries/LibWeb/CMakeLists.txt | 1 + .../Libraries/LibWeb/Loader/LoadRequest.cpp | 47 +++++++++++++++++++ .../Libraries/LibWeb/Loader/LoadRequest.h | 2 + 3 files changed, 50 insertions(+) create mode 100644 Userland/Libraries/LibWeb/Loader/LoadRequest.cpp diff --git a/Userland/Libraries/LibWeb/CMakeLists.txt b/Userland/Libraries/LibWeb/CMakeLists.txt index e178d9174d..110d3247f1 100644 --- a/Userland/Libraries/LibWeb/CMakeLists.txt +++ b/Userland/Libraries/LibWeb/CMakeLists.txt @@ -193,6 +193,7 @@ set(SOURCES Loader/FrameLoader.cpp Loader/ImageLoader.cpp Loader/ImageResource.cpp + Loader/LoadRequest.cpp Loader/Resource.cpp Loader/ResourceLoader.cpp Namespace.cpp diff --git a/Userland/Libraries/LibWeb/Loader/LoadRequest.cpp b/Userland/Libraries/LibWeb/Loader/LoadRequest.cpp new file mode 100644 index 0000000000..6c5d50d1b3 --- /dev/null +++ b/Userland/Libraries/LibWeb/Loader/LoadRequest.cpp @@ -0,0 +1,47 @@ +/* + * Copyright (c) 2021, Tim Flynn + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * + * 2. Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER + * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#include "LoadRequest.h" +#include +#include + +namespace Web { + +LoadRequest LoadRequest::create_for_url_on_page(const URL& url, Page* page) +{ + LoadRequest request; + request.set_url(url); + + if (page) { + String cookie = page->client().page_did_request_cookie(url, Cookie::Source::Http); + if (!cookie.is_empty()) + request.set_header("Cookie", cookie); + } + + return request; +} + +} diff --git a/Userland/Libraries/LibWeb/Loader/LoadRequest.h b/Userland/Libraries/LibWeb/Loader/LoadRequest.h index 149ce2537c..906c0e4d3b 100644 --- a/Userland/Libraries/LibWeb/Loader/LoadRequest.h +++ b/Userland/Libraries/LibWeb/Loader/LoadRequest.h @@ -39,6 +39,8 @@ public: { } + static LoadRequest create_for_url_on_page(const URL& url, Page* page); + bool is_valid() const { return m_url.is_valid(); } const URL& url() const { return m_url; }