RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:07:34 +00:00
Code Issues Activity Actions

LibJS: Allow assignment expression in spreading property definition

Browse source 
See: https://tc39.es/ecma262/#sec-runtime-semantics-propertydefinitionevaluation
PropertyDefinition : ... AssignmentExpression
Also add a test for this in array spreading, which already had this in
place.
This commit is contained in:
Luke Wilde 2023-08-29 21:38:42 +01:00 • committed by Tim Flynn
parent 766cd852d3
commit 3ceedbd16a
3 changed files with 41 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Parser.cpp
View file

@ -1926,7 +1926,7 @@ NonnullRefPtr<ObjectExpression const> Parser::parse_object_expression()
if (match(TokenType::TripleDot)) { if (match(TokenType::TripleDot)) {
consume(); consume();
property_key = parse_expression(4); property_key = parse_expression(2);
properties.append(create_ast_node<ObjectProperty>({ m_source_code, rule_start.position(), position() }, *property_key, nullptr, ObjectProperty::Type::Spread, false)); properties.append(create_ast_node<ObjectProperty>({ m_source_code, rule_start.position(), position() }, *property_key, nullptr, ObjectProperty::Type::Spread, false));
if (!match(TokenType::Comma)) if (!match(TokenType::Comma))
break; break;

20
Userland/Libraries/LibJS/Tests/builtins/Array/array-spread.js
View file

@ -23,3 +23,23 @@ test("basic functionality", () => {
expect([...[], ...[...[1, 2, 3]], 4]).toEqual([1, 2, 3, 4]); expect([...[], ...[...[1, 2, 3]], 4]).toEqual([1, 2, 3, 4]);
}); });
test("allows assignment expressions", () => {
expect("([ ...a = { hello: 'world' } ])").toEval();
expect("([ ...a += 'hello' ])").toEval();
expect("([ ...a -= 'hello' ])").toEval();
expect("([ ...a **= 'hello' ])").toEval();
expect("([ ...a *= 'hello' ])").toEval();
expect("([ ...a /= 'hello' ])").toEval();
expect("([ ...a %= 'hello' ])").toEval();
expect("([ ...a <<= 'hello' ])").toEval();
expect("([ ...a >>= 'hello' ])").toEval();
expect("([ ...a >>>= 'hello' ])").toEval();
expect("([ ...a &= 'hello' ])").toEval();
expect("([ ...a ^= 'hello' ])").toEval();
expect("([ ...a |= 'hello' ])").toEval();
expect("([ ...a &&= 'hello' ])").toEval();
expect("([ ...a ||= 'hello' ])").toEval();
expect("([ ...a ??= 'hello' ])").toEval();
expect("function* test() { return ([ ...yield a ]); }").toEval();
});

20
Userland/Libraries/LibJS/Tests/object-spread.js
View file

@ -172,3 +172,23 @@ describe("modification of spreadable objects during spread", () => {
expect(arrayResult).toHaveProperty("1000", 1000); expect(arrayResult).toHaveProperty("1000", 1000);
}); });
}); });
test("allows assignment expressions", () => {
expect("({ ...a = { hello: 'world' } })").toEval();
expect("({ ...a += 'hello' })").toEval();
expect("({ ...a -= 'hello' })").toEval();
expect("({ ...a **= 'hello' })").toEval();
expect("({ ...a *= 'hello' })").toEval();
expect("({ ...a /= 'hello' })").toEval();
expect("({ ...a %= 'hello' })").toEval();
expect("({ ...a <<= 'hello' })").toEval();
expect("({ ...a >>= 'hello' })").toEval();
expect("({ ...a >>>= 'hello' })").toEval();
expect("({ ...a &= 'hello' })").toEval();
expect("({ ...a ^= 'hello' })").toEval();
expect("({ ...a |= 'hello' })").toEval();
expect("({ ...a &&= 'hello' })").toEval();
expect("({ ...a ||= 'hello' })").toEval();
expect("({ ...a ??= 'hello' })").toEval();
expect("function* test() { return ({ ...yield a }); }").toEval();
});