RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 03:17:34 +00:00
Code Issues Activity Actions

LibJS: Support the radix argument in BigInt.prototype.toString

Browse source
This commit is contained in:
Idan Horowitz 2021-06-29 17:59:25 +03:00 • committed by Linus Groh
parent 005d75656e
commit 3cfe1a8914
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibJS/Runtime/BigIntPrototype.cpp
View file

@ -52,8 +52,17 @@ JS_DEFINE_NATIVE_FUNCTION(BigIntPrototype::to_string)
auto bigint_value = this_bigint_value(global_object, vm.this_value(global_object)); auto bigint_value = this_bigint_value(global_object, vm.this_value(global_object));
if (vm.exception()) if (vm.exception())
return {}; return {};
// FIXME: Support radix argument double radix = 10;
return js_string(vm, bigint_value.as_bigint().big_integer().to_base(10)); if (!vm.argument(0).is_undefined()) {
radix = vm.argument(0).to_integer_or_infinity(global_object);
if (vm.exception())
return {};
if (radix < 2 || radix > 36) {
vm.throw_exception<RangeError>(global_object, ErrorType::InvalidRadix);
return {};
}
}
return js_string(vm, bigint_value.as_bigint().big_integer().to_base(radix));
} }
// 21.2.3.2 BigInt.prototype.toLocaleString ( [ reserved1 [ , reserved2 ] ] ), https://tc39.es/ecma262/#sec-bigint.prototype.tolocalestring // 21.2.3.2 BigInt.prototype.toLocaleString ( [ reserved1 [ , reserved2 ] ] ), https://tc39.es/ecma262/#sec-bigint.prototype.tolocalestring