RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:47:34 +00:00
Code Issues Activity Actions

Meta+CMake: Remove "image" ninja target in favor of "qemu-image"

Browse source 
"image" was an alias for "qemu-image".

I want to add an `image` userland utility, which clashes with that
shortname.

So remove the existing "image" target. It was just an alias for
"qemu-image".

If you use serenity.sh to build, nothing changes. This only affects you
if you run ninja manually -- you now have to say `ninja qemu-image` to
build the disk image.
This commit is contained in:
Nico Weber 2023-03-11 20:12:37 -05:00 • committed by Linus Groh
parent 952222ec4d
commit 3cff36b7ab
5 changed files with 6 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Documentation/RunningTests.md
View file

@ -79,7 +79,7 @@ For completeness, a basic on-target test run will need the SerenityOS image buil
cmake -GNinja -S Meta/CMake/Superbuild -B Build/superbuild-x86_64
cmake --build Build/superbuild-x86_64
cd Build/x86_64
ninja install && ninja image && ninja run
ninja install && ninja qemu-image && ninja run
```
In the initial terminal, one can easily run the test runner script: