From 3d0b5efcfc06f1aa977fbc1eb074fb54c36e2869 Mon Sep 17 00:00:00 2001 From: Idan Horowitz Date: Wed, 29 Dec 2021 00:41:05 +0200 Subject: [PATCH] Kernel: Remove Process::all_processes() This was only used in ProcFS, which can use the `processes()` list just as well, so let's remove it. --- Kernel/GlobalProcessExposed.cpp | 7 ++++--- Kernel/Process.cpp | 11 ----------- Kernel/Process.h | 2 -- 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/Kernel/GlobalProcessExposed.cpp b/Kernel/GlobalProcessExposed.cpp index 245b57184e..ea2f278cfe 100644 --- a/Kernel/GlobalProcessExposed.cpp +++ b/Kernel/GlobalProcessExposed.cpp @@ -533,10 +533,11 @@ private: { { auto array = json.add_array("processes"); - auto processes = Process::all_processes(); build_process(array, *Scheduler::colonel()); - for (auto& process : processes) - build_process(array, process); + processes().with([&](auto& processes) { + for (auto& process : processes) + build_process(array, process); + }); } auto total_time_scheduled = Scheduler::get_total_time_scheduled(); diff --git a/Kernel/Process.cpp b/Kernel/Process.cpp index 99155ff8cd..3fa3e4d734 100644 --- a/Kernel/Process.cpp +++ b/Kernel/Process.cpp @@ -79,17 +79,6 @@ UNMAP_AFTER_INIT void Process::initialize() create_signal_trampoline(); } -NonnullRefPtrVector Process::all_processes() -{ - NonnullRefPtrVector output; - processes().with([&](const auto& list) { - output.ensure_capacity(list.size_slow()); - for (const auto& process : list) - output.append(NonnullRefPtr(process)); - }); - return output; -} - bool Process::in_group(GroupID gid) const { return this->gid() == gid || extra_gids().contains_slow(gid); diff --git a/Kernel/Process.h b/Kernel/Process.h index dff5e01325..81c699dc6a 100644 --- a/Kernel/Process.h +++ b/Kernel/Process.h @@ -186,8 +186,6 @@ public: bool unref() const; ~Process(); - static NonnullRefPtrVector all_processes(); - RefPtr create_kernel_thread(void (*entry)(void*), void* entry_data, u32 priority, NonnullOwnPtr name, u32 affinity = THREAD_AFFINITY_DEFAULT, bool joinable = true); bool is_profiling() const { return m_profiling; }