RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-10 12:17:35 +00:00
Code Issues Activity Actions

LibWeb: Implement the :target-within pseudo-class selector

Browse source 
As noted in a9620d8784 we don't currently
set the target element so this does not function, so no tests. But it
should work once we have a fleshed out Navigables implementation. :^)
This commit is contained in:
Sam Atkins 2023-08-22 15:55:46 +01:00 • committed by Andreas Kling
parent 3af8b491b4
commit 3d10bf3ae7
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/CSS/PseudoClasses.json
View file

@ -113,6 +113,9 @@
"target": { "target": {
"argument": "" "argument": ""
}, },
"target-within": {
"argument": ""
},
"visited": { "visited": {
"argument": "" "argument": ""
}, },

6
Userland/Libraries/LibWeb/CSS/SelectorEngine.cpp
View file

@ -446,6 +446,12 @@ static inline bool matches_pseudo_class(CSS::Selector::SimpleSelector::PseudoCla
} }
case CSS::PseudoClass::Target: case CSS::PseudoClass::Target:
return element.is_target(); return element.is_target();
case CSS::PseudoClass::TargetWithin: {
auto* target_element = element.document().target_element();
if (!target_element)
return false;
return element.is_inclusive_ancestor_of(*target_element);
}
case CSS::PseudoClass::Dir: { case CSS::PseudoClass::Dir: {
// "Values other than ltr and rtl are not invalid, but do not match anything." // "Values other than ltr and rtl are not invalid, but do not match anything."
// - https://www.w3.org/TR/selectors-4/#the-dir-pseudo // - https://www.w3.org/TR/selectors-4/#the-dir-pseudo