RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 19:38:12 +00:00
Code Issues Activity Actions

LibWeb: Rename "Computed" CSSStyleDeclaration => "Resolved"

Browse source 
The original name was based on the window.getComputedStyle() API.
However, "Computed" in "getComputedStyle" is actually a misnomer that
the platform is stuck with due to backwards compatibility.

What getComputedStyle() returns is actually a mix of computed and used
values. The spec calls it the "resolved" values. So let's call this
declaration subclass "ResolvedCSSStyleDeclaration" to match.
This commit is contained in:
Andreas Kling 2021-09-23 12:35:56 +02:00
parent 058d44dcae
commit 3d36e4d944
5 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

35
Userland/Libraries/LibWeb/CSS/ComputedCSSStyleDeclaration.h
View file

@ -1,35 +0,0 @@
/*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <LibWeb/CSS/CSSStyleDeclaration.h>
namespace Web::CSS {
class ComputedCSSStyleDeclaration final : public CSSStyleDeclaration {
public:
static NonnullRefPtr<ComputedCSSStyleDeclaration> create(DOM::Element& element)
{
return adopt_ref(*new ComputedCSSStyleDeclaration(element));
}
virtual ~ComputedCSSStyleDeclaration() override;
virtual size_t length() const override;
virtual String item(size_t index) const override;
virtual Optional<StyleProperty> property(PropertyID) const override;
virtual bool set_property(PropertyID, StringView css_text) override;
private:
explicit ComputedCSSStyleDeclaration(DOM::Element&);
RefPtr<StyleValue> style_value_for_property(Layout::NodeWithStyle const&, PropertyID) const;
NonnullRefPtr<DOM::Element> m_element;
};
}