From 3d42297ecdf82ddf82ccec8c715468b99e79ab88 Mon Sep 17 00:00:00 2001 From: PAUL007 Date: Tue, 22 Jun 2021 17:30:57 +0530 Subject: [PATCH] Taskbar: Check if executable in .af exist in filesystem This adds access X_OK check in discover_apps_and_categories() to see executable specified in .af files exist before registering them for start menu. --- Userland/Services/Taskbar/main.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Userland/Services/Taskbar/main.cpp b/Userland/Services/Taskbar/main.cpp index 9e98cf3170..76f0c11094 100644 --- a/Userland/Services/Taskbar/main.cpp +++ b/Userland/Services/Taskbar/main.cpp @@ -87,8 +87,10 @@ Vector discover_apps_and_categories() { HashTable seen_app_categories; Desktop::AppFile::for_each([&](auto af) { - g_apps.append({ af->executable(), af->name(), af->category() }); - seen_app_categories.set(af->category()); + if (access(af->executable().characters(), X_OK) == 0) { + g_apps.append({ af->executable(), af->name(), af->category() }); + seen_app_categories.set(af->category()); + } }); quick_sort(g_apps, [](auto& a, auto& b) { return a.name < b.name; });