From 3d74d72bcb9763a695a53bf27114031fe62d146e Mon Sep 17 00:00:00 2001 From: Aliaksandr Kalenik Date: Tue, 22 Nov 2022 22:57:14 +0300 Subject: [PATCH] LibWeb: Do not try to join floats into anonymous block Making floats to join anonymous block caused regressions in Acid2 Test so let's leave it to be only absolute blocks who might be joined into anonymous block when possible. --- Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp b/Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp index 9500d3488c..6227f381df 100644 --- a/Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp +++ b/Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp @@ -84,11 +84,10 @@ static Layout::Node& insertion_parent_for_block_node(Layout::NodeWithStyle& layo return layout_parent; } - if (layout_node.is_floating() || layout_node.is_absolutely_positioned()) { + // TODO: Floats should probably also be able to have inline siblings + if (layout_node.is_absolutely_positioned() && layout_parent.last_child()->children_are_inline()) { // Block is out-of-flow, it can have inline siblings if necessary. - if (layout_parent.last_child()->children_are_inline()) { - return *layout_parent.last_child(); - } + return *layout_parent.last_child(); } if (!layout_parent.children_are_inline()) {