RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:58:11 +00:00
Code Issues Activity Actions

LibJS: Always allocate ExecutionContext objects on the malloc heap

Browse source 
Instead of allocating these in a mixture of ways, we now always put
them on the malloc heap, and keep an intrusive linked list of them
that we can iterate for GC marking purposes.
This commit is contained in:
Andreas Kling 2023-11-27 16:45:45 +01:00
parent 845da3901d
commit 3dc5f467a8
38 changed files with 251 additions and 217 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibJS/SyntheticModule.cpp
View file

@ -79,25 +79,25 @@ ThrowCompletionOr<Promise*> SyntheticModule::evaluate(VM& vm)
// FIXME: We don't have suspend yet.
// 2. Let moduleContext be a new ECMAScript code execution context.
ExecutionContext module_context { vm.heap() };
auto module_context = ExecutionContext::create(vm.heap());
// 3. Set the Function of moduleContext to null.
// Note: This is the default value.
// 4. Set the Realm of moduleContext to module.[[Realm]].
module_context.realm = &realm();
module_context->realm = &realm();
// 5. Set the ScriptOrModule of moduleContext to module.
module_context.script_or_module = NonnullGCPtr<Module>(*this);
module_context->script_or_module = NonnullGCPtr<Module>(*this);
// 6. Set the VariableEnvironment of moduleContext to module.[[Environment]].
module_context.variable_environment = environment();
module_context->variable_environment = environment();
// 7. Set the LexicalEnvironment of moduleContext to module.[[Environment]].
module_context.lexical_environment = environment();
module_context->lexical_environment = environment();
// 8. Push moduleContext on to the execution context stack; moduleContext is now the running execution context.
TRY(vm.push_execution_context(module_context, {}));
TRY(vm.push_execution_context(*module_context, {}));
// 9. Let result be the result of performing module.[[EvaluationSteps]](module).
auto result = m_evaluation_steps(*this);