RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-25 05:22:06 +00:00
Code Issues Activity Actions

LibCore: Make sockets close-on-exec by default

Browse source 
This mirrors the previous default in Core::LocalSocket, and is the safer
default anyway. This prevents fds from living on in other processes when
exec() is called in certain programs such as Assistant.

Fixes #12029.
This commit is contained in:
sin-ack 2022-01-21 14:11:36 +00:00 • committed by Andreas Kling
parent 483ab7fe26
commit 3de51a4b99
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibCore/Stream.cpp
View file

@ -241,7 +241,14 @@ ErrorOr<int> Socket::create_fd(SocketDomain domain, SocketType type)
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();
} }
return System::socket(socket_domain, socket_type, 0); // Let's have a safe default of CLOEXEC. :^)
#ifdef SOCK_CLOEXEC
return System::socket(socket_domain, socket_type | SOCK_CLOEXEC, 0);
#else
auto fd = TRY(System::socket(socket_domain, socket_type, 0));
TRY(System::fcntl(fd, F_SETFD, FD_CLOEXEC));
return fd;
#endif
} }
ErrorOr<IPv4Address> Socket::resolve_host(String const& host, SocketType type) ErrorOr<IPv4Address> Socket::resolve_host(String const& host, SocketType type)