RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:37:35 +00:00
Code Issues Activity Actions

Kernel+strace: Remove unnecessary indirection for PEEK

Browse source 
Also, remove incomplete, superfluous check.
Incomplete, because only the byte at the provided address was checked;
this misses the last bytes of the "jerk page".
Superfluous, because it is already correctly checked by peek_user_data
(which calls copy_from_user).

The caller/tracer should not typically attempt to read non-userspace
addresses, we don't need to "hot-path" it either.
This commit is contained in:
Ben Wiederhake 2021-11-25 20:15:02 +01:00 • committed by Andreas Kling
parent 6f37510a71
commit 3e223185b3
3 changed files with 5 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/API/Syscall.h
View file

@ -465,11 +465,6 @@ struct SC_ptrace_params {
FlatPtr data;
};
struct SC_ptrace_peek_params {
const void* address;
FlatPtr* out_data;
};
struct SC_set_coredump_metadata_params {
StringArgument key;
StringArgument value;