RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 03:27:44 +00:00
Code Issues Activity Actions

LibWeb: Do not issue change event for every update of color input

Browse source 
Per spec, the change event shall only be issued once the change is
finally committed by the user, IE by closing the color picker window.
This commit is contained in:
circl 2024-03-02 18:06:44 +01:00 • committed by Andreas Kling
parent bad7f0091f
commit 3e3a200eee
3 changed files with 14 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -348,7 +348,7 @@ void HTMLInputElement::did_edit_text_node(Badge<BrowsingContext>)
}); });
} }
void HTMLInputElement::did_pick_color(Optional<Color> picked_color) void HTMLInputElement::did_pick_color(Optional<Color> picked_color, ColorPickerUpdateState state)
{ {
// https://html.spec.whatwg.org/multipage/input.html#common-input-element-events // https://html.spec.whatwg.org/multipage/input.html#common-input-element-events
// For input elements without a defined input activation behavior, but to which these events apply // For input elements without a defined input activation behavior, but to which these events apply
@ -371,14 +371,16 @@ void HTMLInputElement::did_pick_color(Optional<Color> picked_color)
}); });
// and any time the user commits the change, the user agent must queue an element task on the user interaction task source // and any time the user commits the change, the user agent must queue an element task on the user interaction task source
queue_an_element_task(HTML::Task::Source::UserInteraction, [this] { if (state == ColorPickerUpdateState::Closed) {
// given the input element queue_an_element_task(HTML::Task::Source::UserInteraction, [this] {
// FIXME: to set its user interacted to true // given the input element
// and fire an event named change at the input element, with the bubbles attribute initialized to true. // FIXME: to set its user interacted to true
auto change_event = DOM::Event::create(realm(), HTML::EventNames::change); // and fire an event named change at the input element, with the bubbles attribute initialized to true.
change_event->set_bubbles(true); auto change_event = DOM::Event::create(realm(), HTML::EventNames::change);
dispatch_event(*change_event); change_event->set_bubbles(true);
}); dispatch_event(*change_event);
});
}
} }
} }

3
Userland/Libraries/LibWeb/HTML/HTMLInputElement.h
View file

@ -11,6 +11,7 @@
#include <LibWeb/DOM/DocumentLoadEventDelayer.h> #include <LibWeb/DOM/DocumentLoadEventDelayer.h>
#include <LibWeb/DOM/Text.h> #include <LibWeb/DOM/Text.h>
#include <LibWeb/FileAPI/FileList.h> #include <LibWeb/FileAPI/FileList.h>
#include <LibWeb/HTML/ColorPickerUpdateState.h>
#include <LibWeb/HTML/FormAssociatedElement.h> #include <LibWeb/HTML/FormAssociatedElement.h>
#include <LibWeb/HTML/HTMLElement.h> #include <LibWeb/HTML/HTMLElement.h>
#include <LibWeb/Layout/ImageProvider.h> #include <LibWeb/Layout/ImageProvider.h>
@ -92,7 +93,7 @@ public:
bool is_mutable() const { return m_is_mutable; } bool is_mutable() const { return m_is_mutable; }
void did_pick_color(Optional<Color> picked_color); void did_pick_color(Optional<Color> picked_color, ColorPickerUpdateState state);
void did_select_files(Span<SelectedFile> selected_files); void did_select_files(Span<SelectedFile> selected_files);

2
Userland/Libraries/LibWeb/Page/Page.cpp
View file

@ -337,7 +337,7 @@ void Page::color_picker_update(Optional<Color> picked_color, HTML::ColorPickerUp
if (m_pending_non_blocking_dialog_target) { if (m_pending_non_blocking_dialog_target) {
auto& input_element = verify_cast<HTML::HTMLInputElement>(*m_pending_non_blocking_dialog_target); auto& input_element = verify_cast<HTML::HTMLInputElement>(*m_pending_non_blocking_dialog_target);
input_element.did_pick_color(move(picked_color)); input_element.did_pick_color(move(picked_color), state);
if (state == HTML::ColorPickerUpdateState::Closed) if (state == HTML::ColorPickerUpdateState::Closed)
m_pending_non_blocking_dialog_target.clear(); m_pending_non_blocking_dialog_target.clear();
} }