RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:07:35 +00:00
Code Issues Activity Actions

Kernel/NVMe: Use a struct for the namespace features, instead of a Tuple

Browse source
This commit is contained in:
Hendiadyoin1 2024-02-29 16:32:03 +01:00 • committed by Andrew Kaster
parent fe0fde2154
commit 3e3b34ab8a
2 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/Devices/Storage/NVMe/NVMeController.h
View file

@ -8,7 +8,6 @@
#include <AK/OwnPtr.h>
#include <AK/Time.h>
#include <AK/Tuple.h>
#include <AK/Types.h>
#include <Kernel/Bus/PCI/Device.h>
#include <Kernel/Devices/Storage/NVMe/NVMeDefinitions.h>
@ -55,11 +54,16 @@ public:
void set_admin_queue_ready_flag() { m_admin_queue_ready = true; }
private:
struct NSFeatures {
u64 namespace_size;
u8 lba_size;
};
NVMeController(PCI::DeviceIdentifier const&, u32 hardware_relative_controller_id);
ErrorOr<void> identify_and_init_namespaces();
ErrorOr<void> identify_and_init_controller();
Tuple<u64, u8> get_ns_features(IdentifyNamespace& identify_data_struct);
NSFeatures get_ns_features(IdentifyNamespace& identify_data_struct);
ErrorOr<void> create_admin_queue(QueueType queue_type);
ErrorOr<void> create_io_queue(u8 qid, QueueType queue_type);
void calculate_doorbell_stride()