RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 15:12:45 +00:00
Code Issues Activity Actions

Ladybird: Abstract spawning helper processes into separate methods

Browse source 
This will let us use the same path discovery methods for WebContent,
SQLServer, and any other helper processes we need to launch.
This commit is contained in:
Andrew Kaster 2023-02-02 03:00:30 -07:00 • committed by Andrew Kaster
parent 792258afe8
commit 3e6d790cf0
4 changed files with 56 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Ladybird/WebContentView.cpp
View file

@ -9,6 +9,7 @@
#include "WebContentView.h"
#include "ConsoleWidget.h"
#include "HelperProcess.h"
#include "InspectorWidget.h"
#include "Utilities.h"
#include <AK/Assertions.h>
@ -586,12 +587,7 @@ void WebContentView::create_client()
arguments.append(m_webdriver_content_ipc_path);
}
auto result = Core::System::exec("./WebContent/WebContent"sv, arguments, Core::System::SearchInPath::Yes);
if (result.is_error()) {
auto web_content_path = ak_deprecated_string_from_qstring(QCoreApplication::applicationDirPath() + "/WebContent");
result = Core::System::exec(web_content_path, arguments, Core::System::SearchInPath::Yes);
}
auto result = spawn_helper_process("WebContent"sv, arguments, Core::System::SearchInPath::Yes);
if (result.is_error())
warnln("Could not launch WebContent: {}", result.error());
VERIFY_NOT_REACHED();