RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-08-02 03:57:45 +00:00
Code Issues Activity Actions

AK+Everywhere: Turn bool keep_empty to an enum in split* functions

Browse source
This commit is contained in:
demostanis 2022-10-22 15:38:21 +02:00 • committed by Linus Groh
parent f485db2501
commit 3e8b5ac920
44 changed files with 96 additions and 81 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Utilities/chown.cpp
View file

@ -39,7 +39,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
uid_t new_uid = -1;
gid_t new_gid = -1;
auto parts = spec.split_view(':', true);
auto parts = spec.split_view(':', SplitBehavior::KeepEmpty);
if (parts[0].is_empty() || (parts.size() == 2 && parts[1].is_empty()) || parts.size() > 2) {
warnln("Invalid uid/gid spec");
return 1;

2
Userland/Utilities/cp.cpp
View file

@ -39,7 +39,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
bool values_ok = true;
StringView { s, strlen(s) }.for_each_split_view(',', false, [&](StringView value) {
StringView { s, strlen(s) }.for_each_split_view(',', SplitBehavior::Nothing, [&](StringView value) {
if (value == "mode"sv) {
preserve |= Core::File::PreserveMode::Permissions;
} else if (value == "ownership"sv) {

2
Userland/Utilities/dd.cpp
View file

@ -38,7 +38,7 @@ enum Status {
static StringView split_at_equals(StringView argument)
{
auto values = argument.split_view('=', true);
auto values = argument.split_view('=', SplitBehavior::KeepEmpty);
if (values.size() < 2) {
warnln("Unable to parse: {}", argument);
return {};

2
Userland/Utilities/readelf.cpp
View file

@ -730,7 +730,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
if (maybe_section.has_value()) {
outln("String dump of section \'{}\':", string_dump_section);
StringView data(maybe_section->raw_data(), maybe_section->size());
data.for_each_split_view('\0', false, [&data](auto string) {
data.for_each_split_view('\0', SplitBehavior::Nothing, [&data](auto string) {
auto offset = string.characters_without_null_termination() - data.characters_without_null_termination();
outln("[{:6x}] {}", offset, string);
});

2
Userland/Utilities/xargs.cpp
View file

@ -245,7 +245,7 @@ ParsedInitialArguments::ParsedInitialArguments(Vector<String>& arguments, String
if (placeholder.is_empty()) {
m_all_parts.append({ arg });
} else {
auto parts = arg.view().split_view(placeholder, true);
auto parts = arg.view().split_view(placeholder, SplitBehavior::KeepEmpty);
some_argument_has_placeholder = some_argument_has_placeholder || parts.size() > 1;
m_all_parts.append(move(parts));
}