RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:27:35 +00:00
Code Issues Activity Actions

LibWeb: Treat non-finite containing block width as zero for percentages

Browse source 
Fixes an assertion when loading https://bun.sh/
This commit is contained in:
Andreas Kling 2023-07-01 08:27:47 +02:00
parent c0a5787395
commit 3f022f4040
3 changed files with 18 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Tests/LibWeb/Layout/expected/block-and-inline/percentage-min-width-with-max-content-containing-block-width.txt Normal file
View file

@ -0,0 +1,8 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x33.46875 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 200x17.46875 children: not-inline
BlockContainer <div> at (8,8) content-size 200x17.46875 children: inline
line 0 width: 36.84375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 5, rect: [8,8 36.84375x17.46875]
"hello"
TextNode <#text>

9
Tests/LibWeb/Layout/input/block-and-inline/percentage-min-width-with-max-content-containing-block-width.html Normal file
View file

@ -0,0 +1,9 @@
<!doctype html><style>
body {
width: max-content;
}
div {
width: 200px;
min-width: 100%;
}
</style><body><div>hello

2
Userland/Libraries/LibWeb/Layout/FormattingContext.cpp
View file

@ -1372,7 +1372,7 @@ CSSPixels FormattingContext::calculate_max_content_height(Layout::Box const& box
CSS::Length FormattingContext::calculate_inner_width(Layout::Box const& box, AvailableSize const& available_width, CSS::Size const& width) const CSS::Length FormattingContext::calculate_inner_width(Layout::Box const& box, AvailableSize const& available_width, CSS::Size const& width) const
{ {
auto width_of_containing_block = available_width.to_px(); auto width_of_containing_block = available_width.to_px_or_zero();
auto width_of_containing_block_as_length_for_resolve = CSS::Length::make_px(width_of_containing_block); auto width_of_containing_block_as_length_for_resolve = CSS::Length::make_px(width_of_containing_block);
if (width.is_auto()) { if (width.is_auto()) {
return width.resolved(box, width_of_containing_block_as_length_for_resolve); return width.resolved(box, width_of_containing_block_as_length_for_resolve);