RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 08:54:58 +00:00
Code Issues Activity Actions

disasm: Allow disassembling just one symbol

Browse source 
This is done in a crude way for now in that we
disassemble all instructions up to the symbol without printing them.
This commit is contained in:
kleines Filmröllchen 2023-10-17 19:05:27 +02:00 • committed by Andrew Kaster
parent 10a1b0de96
commit 3f0a77e788
1 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Utilities/disasm.cpp
View file

@ -41,12 +41,14 @@ struct Symbol {
ErrorOr<int> serenity_main(Main::Arguments args) ErrorOr<int> serenity_main(Main::Arguments args)
{ {
StringView path {}; StringView path {};
StringView target_symbol;
Core::ArgsParser args_parser; Core::ArgsParser args_parser;
args_parser.set_general_help( args_parser.set_general_help(
"Disassemble an executable, and show human-readable " "Disassemble an executable, and show human-readable "
"assembly code for each function."); "assembly code for each function.");
args_parser.add_positional_argument(path, "Path to i386 binary file", "path"); args_parser.add_positional_argument(path, "Path to binary file", "path");
args_parser.add_option(target_symbol, "Show disassembly only for a specific symbol", "symbol", 's', "symbol");
args_parser.parse(args); args_parser.parse(args);
OwnPtr<Core::MappedFile> file; OwnPtr<Core::MappedFile> file;
@ -120,6 +122,7 @@ ErrorOr<int> serenity_main(Main::Arguments args)
Vector<Symbol>::Iterator current_zero_size_symbol = zero_size_symbols.begin(); Vector<Symbol>::Iterator current_zero_size_symbol = zero_size_symbols.begin();
bool is_first_symbol = true; bool is_first_symbol = true;
bool current_instruction_is_in_symbol = false; bool current_instruction_is_in_symbol = false;
bool found_symbol = false;
for (;;) { for (;;) {
auto offset = stream.offset(); auto offset = stream.offset();
@ -182,6 +185,16 @@ ErrorOr<int> serenity_main(Main::Arguments args)
is_first_symbol = false; is_first_symbol = false;
} }
// Past the target symbol now; no need to disassemble more.
if (found_symbol && current_ranged_symbol->name != target_symbol)
break;
found_symbol = !target_symbol.is_empty() && current_ranged_symbol->name == target_symbol;
// We have not found the target symbol yet; don't print anything.
if (!target_symbol.is_empty() && current_ranged_symbol->name != target_symbol)
continue;
// Insert extra newline after the "dangling" symbols. // Insert extra newline after the "dangling" symbols.
if (needs_separator) if (needs_separator)
outln(); outln();