mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 06:17:35 +00:00
LoginServer+LibCore: Only create user temp directory from LoginServer
Other programs use Core::Account::login(), notably su(1), which stopped working due to a missing "cpath" pledge promise. This patch moves the /tmp/user/ creation logic to a separate function that LoginServer can call.
This commit is contained in:
parent
32642394a9
commit
3f14582b85
3 changed files with 14 additions and 8 deletions
|
@ -149,17 +149,16 @@ bool Account::authenticate(SecretString const& password) const
|
|||
return hash != nullptr && AK::timing_safe_compare(hash, m_password_hash.characters(), m_password_hash.length());
|
||||
}
|
||||
|
||||
bool Account::login() const
|
||||
ErrorOr<void> Account::create_user_temporary_directory_if_needed() const
|
||||
{
|
||||
auto const temporary_directory = String::formatted("/tmp/user/{}", m_uid);
|
||||
if (auto result = Core::Directory::create(temporary_directory, Core::Directory::CreateDirectories::Yes); result.is_error()) {
|
||||
dbgln("{}", result.release_error());
|
||||
return false;
|
||||
}
|
||||
|
||||
if (chown(temporary_directory.characters(), m_uid, m_gid) < 0)
|
||||
return false;
|
||||
TRY(Core::Directory::create(temporary_directory, Core::Directory::CreateDirectories::Yes));
|
||||
TRY(Core::System::chown(temporary_directory, m_uid, m_gid));
|
||||
return {};
|
||||
}
|
||||
|
||||
bool Account::login() const
|
||||
{
|
||||
if (setgroups(m_extra_gids.size(), m_extra_gids.data()) < 0)
|
||||
return false;
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue