mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 04:17:35 +00:00
Userland: Prefer _string
over _short_string
As `_string` can't fail anymore (since 3434412
), there are no real
benefits to use the short variant in most cases.
This commit is contained in:
parent
a5edc9cdfc
commit
3f35ffb648
198 changed files with 684 additions and 684 deletions
|
@ -65,13 +65,13 @@ enum class ValueID;
|
|||
// Find the smallest possible type to use.
|
||||
auto member_max_value = members.size() - 1;
|
||||
if (NumericLimits<u8>::max() >= member_max_value) {
|
||||
TRY(enum_generator.set("enum_type", "u8"_short_string));
|
||||
TRY(enum_generator.set("enum_type", "u8"_string));
|
||||
} else if (NumericLimits<u16>::max() >= member_max_value) {
|
||||
TRY(enum_generator.set("enum_type", "u16"_short_string));
|
||||
TRY(enum_generator.set("enum_type", "u16"_string));
|
||||
} else if (NumericLimits<u32>::max() >= member_max_value) {
|
||||
TRY(enum_generator.set("enum_type", "u32"_short_string));
|
||||
TRY(enum_generator.set("enum_type", "u32"_string));
|
||||
} else {
|
||||
TRY(enum_generator.set("enum_type", "u64"_short_string));
|
||||
TRY(enum_generator.set("enum_type", "u64"_string));
|
||||
}
|
||||
|
||||
TRY(enum_generator.try_appendln("enum class @name:titlecase@ : @enum_type@ {"));
|
||||
|
|
|
@ -249,7 +249,7 @@ ErrorOr<OwnPtr<CalculationNode>> Parser::parse_math_function(PropertyID property
|
|||
if (auto default_value = parameter.get_deprecated_string("default"sv); default_value.has_value()) {
|
||||
TRY(parameter_generator.set("parameter_default", TRY(String::formatted(" = RoundingStrategy::{}", TRY(title_casify(default_value.value()))))));
|
||||
} else {
|
||||
TRY(parameter_generator.set("parameter_default", ""_short_string));
|
||||
TRY(parameter_generator.set("parameter_default", ""_string));
|
||||
}
|
||||
} else {
|
||||
// NOTE: This assumes everything not handled above is a calculation node of some kind.
|
||||
|
@ -264,7 +264,7 @@ ErrorOr<OwnPtr<CalculationNode>> Parser::parse_math_function(PropertyID property
|
|||
if (auto default_value = parameter.get_deprecated_string("default"sv); default_value.has_value()) {
|
||||
TRY(parameter_generator.set("parameter_default", TRY(String::formatted(" = TRY(ConstantCalculationNode::create(CalculationNode::constant_type_from_string(\"{}\"sv).value()))", TRY(String::from_deprecated_string(default_value.value()))))));
|
||||
} else {
|
||||
TRY(parameter_generator.set("parameter_default", ""_short_string));
|
||||
TRY(parameter_generator.set("parameter_default", ""_string));
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -351,7 +351,7 @@ ErrorOr<OwnPtr<CalculationNode>> Parser::parse_math_function(PropertyID property
|
|||
TRY(parameter_generator.set("parameter_index"sv, TRY(String::number(parameter_index))));
|
||||
|
||||
if (parameter_type_string == "<rounding-strategy>"sv) {
|
||||
TRY(parameter_generator.set("release_value"sv, ""_short_string));
|
||||
TRY(parameter_generator.set("release_value"sv, ""_string));
|
||||
} else {
|
||||
// NOTE: This assumes everything not handled above is a calculation node of some kind.
|
||||
TRY(parameter_generator.set("release_value"sv, ".release_nonnull()"_string));
|
||||
|
|
|
@ -145,7 +145,7 @@ bool media_feature_type_is_range(MediaFeatureID media_feature_id)
|
|||
VERIFY(feature.has("type"sv));
|
||||
auto feature_type = feature.get_deprecated_string("type"sv);
|
||||
VERIFY(feature_type.has_value());
|
||||
TRY(member_generator.set("is_range", feature_type.value() == "range" ? "true"_short_string : "false"_short_string));
|
||||
TRY(member_generator.set("is_range", feature_type.value() == "range" ? "true"_string : "false"_string));
|
||||
TRY(member_generator.try_append(R"~~~(
|
||||
case MediaFeatureID::@name:titlecase@:
|
||||
return @is_range@;)~~~"));
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue