RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:38:10 +00:00
Code Issues Activity Actions

Userland: Prefer _string over _short_string

Browse source 
As `_string` can't fail anymore (since 3434412), there are no real
benefits to use the short variant in most cases.
This commit is contained in:
Lucas CHOLLET 2023-08-07 22:26:17 -04:00 • committed by Andreas Kling
parent a5edc9cdfc
commit 3f35ffb648
198 changed files with 684 additions and 684 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSEnums.cpp
View file

@ -65,13 +65,13 @@ enum class ValueID;
// Find the smallest possible type to use.
auto member_max_value = members.size() - 1;
if (NumericLimits<u8>::max() >= member_max_value) {
TRY(enum_generator.set("enum_type", "u8"_short_string));
TRY(enum_generator.set("enum_type", "u8"_string));
} else if (NumericLimits<u16>::max() >= member_max_value) {
TRY(enum_generator.set("enum_type", "u16"_short_string));
TRY(enum_generator.set("enum_type", "u16"_string));
} else if (NumericLimits<u32>::max() >= member_max_value) {
TRY(enum_generator.set("enum_type", "u32"_short_string));
TRY(enum_generator.set("enum_type", "u32"_string));
} else {
TRY(enum_generator.set("enum_type", "u64"_short_string));
TRY(enum_generator.set("enum_type", "u64"_string));
}
TRY(enum_generator.try_appendln("enum class @name:titlecase@ : @enum_type@ {"));