mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 16:47:34 +00:00
Userland: Prefer _string
over _short_string
As `_string` can't fail anymore (since 3434412
), there are no real
benefits to use the short variant in most cases.
This commit is contained in:
parent
a5edc9cdfc
commit
3f35ffb648
198 changed files with 684 additions and 684 deletions
|
@ -48,7 +48,7 @@ ErrorOr<void> MainWidget::initialize()
|
|||
|
||||
m_roll_widget->set_fixed_height(300);
|
||||
|
||||
(void)TRY(m_tab_widget->try_add_tab<SamplerWidget>("Sampler"_short_string, m_track_manager));
|
||||
(void)TRY(m_tab_widget->try_add_tab<SamplerWidget>("Sampler"_string, m_track_manager));
|
||||
m_player_widget = TRY(try_add<PlayerWidget>(m_track_manager, *this, m_audio_loop));
|
||||
|
||||
m_keys_and_knobs_container = TRY(try_add<GUI::Widget>());
|
||||
|
@ -61,7 +61,7 @@ ErrorOr<void> MainWidget::initialize()
|
|||
m_octave_container = TRY(m_keys_and_knobs_container->try_add<GUI::Widget>());
|
||||
m_octave_container->set_preferred_width(GUI::SpecialDimension::Fit);
|
||||
TRY(m_octave_container->try_set_layout<GUI::VerticalBoxLayout>());
|
||||
auto octave_label = TRY(m_octave_container->try_add<GUI::Label>("Octave"_short_string));
|
||||
auto octave_label = TRY(m_octave_container->try_add<GUI::Label>("Octave"_string));
|
||||
octave_label->set_preferred_width(GUI::SpecialDimension::Fit);
|
||||
m_octave_value = TRY(m_octave_container->try_add<GUI::Label>(TRY(String::number(m_track_manager.keyboard()->virtual_keyboard_octave()))));
|
||||
m_octave_value->set_preferred_width(GUI::SpecialDimension::Fit);
|
||||
|
|
|
@ -45,7 +45,7 @@ ErrorOr<void> PlayerWidget::initialize()
|
|||
set_fill_with_background_color(true);
|
||||
TRY(m_track_number_choices.try_append("1"));
|
||||
|
||||
RefPtr<GUI::Label> label = TRY(try_add<GUI::Label>("Track"_short_string));
|
||||
RefPtr<GUI::Label> label = TRY(try_add<GUI::Label>("Track"_string));
|
||||
label->set_max_width(75);
|
||||
|
||||
m_track_dropdown = TRY(try_add<GUI::ComboBox>());
|
||||
|
|
|
@ -58,7 +58,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
|
|||
}));
|
||||
main_widget_updater->start();
|
||||
|
||||
auto file_menu = TRY(window->try_add_menu("&File"_short_string));
|
||||
auto file_menu = TRY(window->try_add_menu("&File"_string));
|
||||
TRY(file_menu->try_add_action(GUI::Action::create("Export...", { Mod_Ctrl, Key_E }, TRY(Gfx::Bitmap::load_from_file("/res/icons/16x16/file-export.png"sv)), [&](const GUI::Action&) {
|
||||
save_path = GUI::FilePicker::get_save_filepath(window, "Untitled", "wav");
|
||||
if (!save_path.has_value())
|
||||
|
@ -83,10 +83,10 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
|
|||
return;
|
||||
})));
|
||||
|
||||
auto edit_menu = TRY(window->try_add_menu("&Edit"_short_string));
|
||||
auto edit_menu = TRY(window->try_add_menu("&Edit"_string));
|
||||
TRY(main_widget->add_track_actions(edit_menu));
|
||||
|
||||
auto help_menu = TRY(window->try_add_menu("&Help"_short_string));
|
||||
auto help_menu = TRY(window->try_add_menu("&Help"_string));
|
||||
TRY(help_menu->try_add_action(GUI::CommonActions::make_command_palette_action(window)));
|
||||
TRY(help_menu->try_add_action(GUI::CommonActions::make_about_action("Piano", app_icon, window)));
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue