mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 06:27:45 +00:00
Userland: Prefer _string
over _short_string
As `_string` can't fail anymore (since 3434412
), there are no real
benefits to use the short variant in most cases.
This commit is contained in:
parent
a5edc9cdfc
commit
3f35ffb648
198 changed files with 684 additions and 684 deletions
|
@ -61,15 +61,15 @@ ErrorOr<String> PlaylistModel::column_name(int column) const
|
|||
{
|
||||
switch (column) {
|
||||
case Column::Title:
|
||||
return "Title"_short_string;
|
||||
return "Title"_string;
|
||||
case Column::Duration:
|
||||
return "Duration"_string;
|
||||
case Column::Group:
|
||||
return "Group"_short_string;
|
||||
return "Group"_string;
|
||||
case Column::Album:
|
||||
return "Album"_short_string;
|
||||
return "Album"_string;
|
||||
case Column::Artist:
|
||||
return "Artist"_short_string;
|
||||
return "Artist"_string;
|
||||
case Column::Filesize:
|
||||
return "Filesize"_string;
|
||||
}
|
||||
|
|
|
@ -253,7 +253,7 @@ void SoundPlayerWidget::file_name_changed(StringView name)
|
|||
DeprecatedString title = name;
|
||||
if (playback_manager().loader()) {
|
||||
auto const& metadata = playback_manager().loader()->metadata();
|
||||
if (auto artists_or_error = metadata.all_artists(" / "_short_string);
|
||||
if (auto artists_or_error = metadata.all_artists(" / "_string);
|
||||
!artists_or_error.is_error() && artists_or_error.value().has_value() && metadata.title.has_value()) {
|
||||
title = DeprecatedString::formatted("{} – {}", metadata.title.value(), artists_or_error.release_value().release_value());
|
||||
} else if (metadata.title.has_value()) {
|
||||
|
|
|
@ -60,7 +60,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
|
|||
player->set_loop_mode(Player::LoopMode::Playlist);
|
||||
}
|
||||
|
||||
auto file_menu = TRY(window->try_add_menu("&File"_short_string));
|
||||
auto file_menu = TRY(window->try_add_menu("&File"_string));
|
||||
TRY(file_menu->try_add_action(GUI::CommonActions::make_open_action([&](auto&) {
|
||||
Optional<DeprecatedString> path = GUI::FilePicker::get_open_filepath(window);
|
||||
if (path.has_value()) {
|
||||
|
@ -163,7 +163,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
|
|||
|
||||
selected_visualization_widget->set_checked(true);
|
||||
|
||||
auto help_menu = TRY(window->try_add_menu("&Help"_short_string));
|
||||
auto help_menu = TRY(window->try_add_menu("&Help"_string));
|
||||
TRY(help_menu->try_add_action(GUI::CommonActions::make_command_palette_action(window)));
|
||||
TRY(help_menu->try_add_action(GUI::CommonActions::make_about_action("Sound Player", app_icon, window)));
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue