RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:27:44 +00:00
Code Issues Activity Actions

Userland: Prefer _string over _short_string

Browse source 
As `_string` can't fail anymore (since 3434412), there are no real
benefits to use the short variant in most cases.
This commit is contained in:
Lucas CHOLLET 2023-08-07 22:26:17 -04:00 • committed by Andreas Kling
parent a5edc9cdfc
commit 3f35ffb648
198 changed files with 684 additions and 684 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Utilities/ps.cpp
View file

@ -93,10 +93,10 @@ static ErrorOr<String> column_to_string(ColumnId column_id, Core::ProcessStatist
case ColumnId::SessionId:
return String::number(process.sid);
case ColumnId::TTY:
return process.tty == "" ? "n/a"_short_string : String::from_deprecated_string(process.tty);
return process.tty == "" ? "n/a"_string : String::from_deprecated_string(process.tty);
case ColumnId::State:
return process.threads.is_empty()
? "Zombie"_short_string
? "Zombie"_string
: String::from_deprecated_string(process.threads.first().state);
case ColumnId::Command:
return String::from_deprecated_string(process.name);
@ -141,7 +141,7 @@ static ErrorOr<String> determine_tty_pseudo_name()
{
auto tty_stat = TRY(Core::System::fstat(STDIN_FILENO));
auto maybe_tty_pseudo_name = TRY(tty_stat_to_pseudo_name(tty_stat));
return maybe_tty_pseudo_name.value_or("n/a"_short_string);
return maybe_tty_pseudo_name.value_or("n/a"_string);
}
static ErrorOr<String> parse_tty_pseudo_name(StringView tty_name)