RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:48:14 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

84
Kernel/PerformanceEventBuffer.cpp
View file

@ -191,7 +191,7 @@ template<typename Serializer>
ErrorOr<void> PerformanceEventBuffer::to_json_impl(Serializer& object) const
{
{
auto strings = TRY(object.add_array("strings"));
auto strings = TRY(object.add_array("strings"sv));
Vector<KString*> strings_sorted_by_index;
TRY(strings_sorted_by_index.try_resize(m_strings.size()));
@ -207,7 +207,7 @@ ErrorOr<void> PerformanceEventBuffer::to_json_impl(Serializer& object) const
}
bool show_kernel_addresses = Process::current().is_superuser();
auto array = TRY(object.add_array("events"));
auto array = TRY(object.add_array("events"sv));
bool seen_first_sample = false;
for (size_t i = 0; i < m_count; ++i) {
auto const& event = at(i);
@ -220,67 +220,67 @@ ErrorOr<void> PerformanceEventBuffer::to_json_impl(Serializer& object) const
auto event_object = TRY(array.add_object());
switch (event.type) {
case PERF_EVENT_SAMPLE:
TRY(event_object.add("type", "sample"));
TRY(event_object.add("type"sv, "sample"));
break;
case PERF_EVENT_MALLOC:
TRY(event_object.add("type", "malloc"));
TRY(event_object.add("ptr", static_cast<u64>(event.data.malloc.ptr)));
TRY(event_object.add("size", static_cast<u64>(event.data.malloc.size)));
TRY(event_object.add("type"sv, "malloc"));
TRY(event_object.add("ptr"sv, static_cast<u64>(event.data.malloc.ptr)));
TRY(event_object.add("size"sv, static_cast<u64>(event.data.malloc.size)));
break;
case PERF_EVENT_FREE:
TRY(event_object.add("type", "free"));
TRY(event_object.add("ptr", static_cast<u64>(event.data.free.ptr)));
TRY(event_object.add("type"sv, "free"));
TRY(event_object.add("ptr"sv, static_cast<u64>(event.data.free.ptr)));
break;
case PERF_EVENT_MMAP:
TRY(event_object.add("type", "mmap"));
TRY(event_object.add("ptr", static_cast<u64>(event.data.mmap.ptr)));
TRY(event_object.add("size", static_cast<u64>(event.data.mmap.size)));
TRY(event_object.add("name", event.data.mmap.name));
TRY(event_object.add("type"sv, "mmap"));
TRY(event_object.add("ptr"sv, static_cast<u64>(event.data.mmap.ptr)));
TRY(event_object.add("size"sv, static_cast<u64>(event.data.mmap.size)));
TRY(event_object.add("name"sv, event.data.mmap.name));
break;
case PERF_EVENT_MUNMAP:
TRY(event_object.add("type", "munmap"));
TRY(event_object.add("ptr", static_cast<u64>(event.data.munmap.ptr)));
TRY(event_object.add("size", static_cast<u64>(event.data.munmap.size)));
TRY(event_object.add("type"sv, "munmap"));
TRY(event_object.add("ptr"sv, static_cast<u64>(event.data.munmap.ptr)));
TRY(event_object.add("size"sv, static_cast<u64>(event.data.munmap.size)));
break;
case PERF_EVENT_PROCESS_CREATE:
TRY(event_object.add("type", "process_create"));
TRY(event_object.add("parent_pid", static_cast<u64>(event.data.process_create.parent_pid)));
TRY(event_object.add("executable", event.data.process_create.executable));
TRY(event_object.add("type"sv, "process_create"));
TRY(event_object.add("parent_pid"sv, static_cast<u64>(event.data.process_create.parent_pid)));
TRY(event_object.add("executable"sv, event.data.process_create.executable));
break;
case PERF_EVENT_PROCESS_EXEC:
TRY(event_object.add("type", "process_exec"));
TRY(event_object.add("executable", event.data.process_exec.executable));
TRY(event_object.add("type"sv, "process_exec"));
TRY(event_object.add("executable"sv, event.data.process_exec.executable));
break;
case PERF_EVENT_PROCESS_EXIT:
TRY(event_object.add("type", "process_exit"));
TRY(event_object.add("type"sv, "process_exit"));
break;
case PERF_EVENT_THREAD_CREATE:
TRY(event_object.add("type", "thread_create"));
TRY(event_object.add("parent_tid", static_cast<u64>(event.data.thread_create.parent_tid)));
TRY(event_object.add("type"sv, "thread_create"));
TRY(event_object.add("parent_tid"sv, static_cast<u64>(event.data.thread_create.parent_tid)));
break;
case PERF_EVENT_THREAD_EXIT:
TRY(event_object.add("type", "thread_exit"));
TRY(event_object.add("type"sv, "thread_exit"));
break;
case PERF_EVENT_CONTEXT_SWITCH:
TRY(event_object.add("type", "context_switch"));
TRY(event_object.add("next_pid", static_cast<u64>(event.data.context_switch.next_pid)));
TRY(event_object.add("next_tid", static_cast<u64>(event.data.context_switch.next_tid)));
TRY(event_object.add("type"sv, "context_switch"));
TRY(event_object.add("next_pid"sv, static_cast<u64>(event.data.context_switch.next_pid)));
TRY(event_object.add("next_tid"sv, static_cast<u64>(event.data.context_switch.next_tid)));
break;
case PERF_EVENT_KMALLOC:
TRY(event_object.add("type", "kmalloc"));
TRY(event_object.add("ptr", static_cast<u64>(event.data.kmalloc.ptr)));
TRY(event_object.add("size", static_cast<u64>(event.data.kmalloc.size)));
TRY(event_object.add("type"sv, "kmalloc"));
TRY(event_object.add("ptr"sv, static_cast<u64>(event.data.kmalloc.ptr)));
TRY(event_object.add("size"sv, static_cast<u64>(event.data.kmalloc.size)));
break;
case PERF_EVENT_KFREE:
TRY(event_object.add("type", "kfree"));
TRY(event_object.add("ptr", static_cast<u64>(event.data.kfree.ptr)));
TRY(event_object.add("size", static_cast<u64>(event.data.kfree.size)));
TRY(event_object.add("type"sv, "kfree"));
TRY(event_object.add("ptr"sv, static_cast<u64>(event.data.kfree.ptr)));
TRY(event_object.add("size"sv, static_cast<u64>(event.data.kfree.size)));
break;
case PERF_EVENT_PAGE_FAULT:
TRY(event_object.add("type", "page_fault"));
TRY(event_object.add("type"sv, "page_fault"));
break;
case PERF_EVENT_SYSCALL:
TRY(event_object.add("type", "syscall"));
TRY(event_object.add("type"sv, "syscall"));
break;
case PERF_EVENT_SIGNPOST:
TRY(event_object.add("type"sv, "signpost"sv));
@ -288,21 +288,21 @@ ErrorOr<void> PerformanceEventBuffer::to_json_impl(Serializer& object) const
TRY(event_object.add("arg2"sv, event.data.signpost.arg2));
break;
case PERF_EVENT_READ:
TRY(event_object.add("type", "read"));
TRY(event_object.add("fd", event.data.read.fd));
TRY(event_object.add("type"sv, "read"));
TRY(event_object.add("fd"sv, event.data.read.fd));
TRY(event_object.add("size"sv, event.data.read.size));
TRY(event_object.add("filename_index"sv, event.data.read.filename_index));
TRY(event_object.add("start_timestamp"sv, event.data.read.start_timestamp));
TRY(event_object.add("success"sv, event.data.read.success));
break;
}
TRY(event_object.add("pid", event.pid));
TRY(event_object.add("tid", event.tid));
TRY(event_object.add("timestamp", event.timestamp));
TRY(event_object.add("lost_samples", seen_first_sample ? event.lost_samples : 0));
TRY(event_object.add("pid"sv, event.pid));
TRY(event_object.add("tid"sv, event.tid));
TRY(event_object.add("timestamp"sv, event.timestamp));
TRY(event_object.add("lost_samples"sv, seen_first_sample ? event.lost_samples : 0));
if (event.type == PERF_EVENT_SAMPLE)
seen_first_sample = true;
auto stack_array = TRY(event_object.add_array("stack"));
auto stack_array = TRY(event_object.add_array("stack"sv));
for (size_t j = 0; j < event.stack_size; ++j) {
auto address = event.stack[j];
if (!show_kernel_addresses && !Memory::is_user_address(VirtualAddress { address }))