mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 16:22:43 +00:00 
			
		
		
		
	Everywhere: Add sv suffix to strings relying on StringView(char const*)
Each of these strings would previously rely on StringView's char const* constructor overload, which would call __builtin_strlen on the string. Since we now have operator ""sv, we can replace these with much simpler versions. This opens the door to being able to remove StringView(char const*). No functional changes.
This commit is contained in:
		
							parent
							
								
									e5f09ea170
								
							
						
					
					
						commit
						3f3f45580a
					
				
					 762 changed files with 8315 additions and 8316 deletions
				
			
		|  | @ -53,9 +53,9 @@ TEST_CASE(numeric_literal) | |||
|     //       This is obviously inconsistent.
 | ||||
|     //       See the FIXME in lexer.cpp, method consume_exponent() about
 | ||||
|     //       solutions.
 | ||||
|     // EXPECT(parse("1e").is_error());
 | ||||
|     // EXPECT(parse("1a").is_error());
 | ||||
|     // EXPECT(parse("0x").is_error());
 | ||||
|     // EXPECT(parse("1e"sv).is_error());
 | ||||
|     // EXPECT(parse("1a"sv).is_error());
 | ||||
|     // EXPECT(parse("0x"sv).is_error());
 | ||||
| 
 | ||||
|     auto validate = [](StringView sql, double expected_value) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -68,18 +68,18 @@ TEST_CASE(numeric_literal) | |||
|         EXPECT_EQ(literal.value(), expected_value); | ||||
|     }; | ||||
| 
 | ||||
|     validate("123", 123); | ||||
|     validate("3.14", 3.14); | ||||
|     validate("0xA", 10); | ||||
|     validate("0xff", 255); | ||||
|     validate("0x100", 256); | ||||
|     validate("1e3", 1000); | ||||
|     validate("123"sv, 123); | ||||
|     validate("3.14"sv, 3.14); | ||||
|     validate("0xA"sv, 10); | ||||
|     validate("0xff"sv, 255); | ||||
|     validate("0x100"sv, 256); | ||||
|     validate("1e3"sv, 1000); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(string_literal) | ||||
| { | ||||
|     EXPECT(parse("'").is_error()); | ||||
|     EXPECT(parse("'unterminated").is_error()); | ||||
|     EXPECT(parse("'"sv).is_error()); | ||||
|     EXPECT(parse("'unterminated"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, StringView expected_value) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -92,16 +92,16 @@ TEST_CASE(string_literal) | |||
|         EXPECT_EQ(literal.value(), expected_value); | ||||
|     }; | ||||
| 
 | ||||
|     validate("''", ""); | ||||
|     validate("'hello friends'", "hello friends"); | ||||
|     validate("'hello ''friends'''", "hello 'friends'"); | ||||
|     validate("''"sv, ""sv); | ||||
|     validate("'hello friends'"sv, "hello friends"sv); | ||||
|     validate("'hello ''friends'''"sv, "hello 'friends'"sv); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(blob_literal) | ||||
| { | ||||
|     EXPECT(parse("x'").is_error()); | ||||
|     EXPECT(parse("x'unterminated").is_error()); | ||||
|     EXPECT(parse("x'NOTHEX'").is_error()); | ||||
|     EXPECT(parse("x'"sv).is_error()); | ||||
|     EXPECT(parse("x'unterminated"sv).is_error()); | ||||
|     EXPECT(parse("x'NOTHEX'"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, StringView expected_value) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -114,8 +114,8 @@ TEST_CASE(blob_literal) | |||
|         EXPECT_EQ(literal.value(), expected_value); | ||||
|     }; | ||||
| 
 | ||||
|     validate("x''", ""); | ||||
|     validate("x'DEADC0DE'", "DEADC0DE"); | ||||
|     validate("x''"sv, ""sv); | ||||
|     validate("x'DEADC0DE'"sv, "DEADC0DE"sv); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(null_literal) | ||||
|  | @ -128,15 +128,15 @@ TEST_CASE(null_literal) | |||
|         EXPECT(is<SQL::AST::NullLiteral>(*expression)); | ||||
|     }; | ||||
| 
 | ||||
|     validate("NULL"); | ||||
|     validate("NULL"sv); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(column_name) | ||||
| { | ||||
|     EXPECT(parse(".column_name").is_error()); | ||||
|     EXPECT(parse("table_name.").is_error()); | ||||
|     EXPECT(parse("schema_name.table_name.").is_error()); | ||||
|     EXPECT(parse("\"unterminated").is_error()); | ||||
|     EXPECT(parse(".column_name"sv).is_error()); | ||||
|     EXPECT(parse("table_name."sv).is_error()); | ||||
|     EXPECT(parse("schema_name.table_name."sv).is_error()); | ||||
|     EXPECT(parse("\"unterminated"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, StringView expected_schema, StringView expected_table, StringView expected_column) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -151,22 +151,22 @@ TEST_CASE(column_name) | |||
|         EXPECT_EQ(column.column_name(), expected_column); | ||||
|     }; | ||||
| 
 | ||||
|     validate("column_name", {}, {}, "COLUMN_NAME"); | ||||
|     validate("table_name.column_name", {}, "TABLE_NAME", "COLUMN_NAME"); | ||||
|     validate("schema_name.table_name.column_name", "SCHEMA_NAME", "TABLE_NAME", "COLUMN_NAME"); | ||||
|     validate("\"Column_Name\"", {}, {}, "Column_Name"); | ||||
|     validate("\"Column\n_Name\"", {}, {}, "Column\n_Name"); | ||||
|     validate("column_name"sv, {}, {}, "COLUMN_NAME"sv); | ||||
|     validate("table_name.column_name"sv, {}, "TABLE_NAME"sv, "COLUMN_NAME"sv); | ||||
|     validate("schema_name.table_name.column_name"sv, "SCHEMA_NAME"sv, "TABLE_NAME"sv, "COLUMN_NAME"sv); | ||||
|     validate("\"Column_Name\""sv, {}, {}, "Column_Name"sv); | ||||
|     validate("\"Column\n_Name\""sv, {}, {}, "Column\n_Name"sv); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(unary_operator) | ||||
| { | ||||
|     EXPECT(parse("-").is_error()); | ||||
|     EXPECT(parse("--").is_error()); | ||||
|     EXPECT(parse("+").is_error()); | ||||
|     EXPECT(parse("++").is_error()); | ||||
|     EXPECT(parse("~").is_error()); | ||||
|     EXPECT(parse("~~").is_error()); | ||||
|     EXPECT(parse("NOT").is_error()); | ||||
|     EXPECT(parse("-"sv).is_error()); | ||||
|     EXPECT(parse("--"sv).is_error()); | ||||
|     EXPECT(parse("+"sv).is_error()); | ||||
|     EXPECT(parse("++"sv).is_error()); | ||||
|     EXPECT(parse("~"sv).is_error()); | ||||
|     EXPECT(parse("~~"sv).is_error()); | ||||
|     EXPECT(parse("NOT"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, SQL::AST::UnaryOperator expected_operator) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -182,42 +182,42 @@ TEST_CASE(unary_operator) | |||
|         EXPECT(!is<SQL::AST::ErrorExpression>(*secondary_expression)); | ||||
|     }; | ||||
| 
 | ||||
|     validate("-15", SQL::AST::UnaryOperator::Minus); | ||||
|     validate("+15", SQL::AST::UnaryOperator::Plus); | ||||
|     validate("~15", SQL::AST::UnaryOperator::BitwiseNot); | ||||
|     validate("NOT 15", SQL::AST::UnaryOperator::Not); | ||||
|     validate("-15"sv, SQL::AST::UnaryOperator::Minus); | ||||
|     validate("+15"sv, SQL::AST::UnaryOperator::Plus); | ||||
|     validate("~15"sv, SQL::AST::UnaryOperator::BitwiseNot); | ||||
|     validate("NOT 15"sv, SQL::AST::UnaryOperator::Not); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(binary_operator) | ||||
| { | ||||
|     HashMap<StringView, SQL::AST::BinaryOperator> operators { | ||||
|         { "||", SQL::AST::BinaryOperator::Concatenate }, | ||||
|         { "*", SQL::AST::BinaryOperator::Multiplication }, | ||||
|         { "/", SQL::AST::BinaryOperator::Division }, | ||||
|         { "%", SQL::AST::BinaryOperator::Modulo }, | ||||
|         { "+", SQL::AST::BinaryOperator::Plus }, | ||||
|         { "-", SQL::AST::BinaryOperator::Minus }, | ||||
|         { "<<", SQL::AST::BinaryOperator::ShiftLeft }, | ||||
|         { ">>", SQL::AST::BinaryOperator::ShiftRight }, | ||||
|         { "&", SQL::AST::BinaryOperator::BitwiseAnd }, | ||||
|         { "|", SQL::AST::BinaryOperator::BitwiseOr }, | ||||
|         { "<", SQL::AST::BinaryOperator::LessThan }, | ||||
|         { "<=", SQL::AST::BinaryOperator::LessThanEquals }, | ||||
|         { ">", SQL::AST::BinaryOperator::GreaterThan }, | ||||
|         { ">=", SQL::AST::BinaryOperator::GreaterThanEquals }, | ||||
|         { "=", SQL::AST::BinaryOperator::Equals }, | ||||
|         { "==", SQL::AST::BinaryOperator::Equals }, | ||||
|         { "!=", SQL::AST::BinaryOperator::NotEquals }, | ||||
|         { "<>", SQL::AST::BinaryOperator::NotEquals }, | ||||
|         { "AND", SQL::AST::BinaryOperator::And }, | ||||
|         { "OR", SQL::AST::BinaryOperator::Or }, | ||||
|         { "||"sv, SQL::AST::BinaryOperator::Concatenate }, | ||||
|         { "*"sv, SQL::AST::BinaryOperator::Multiplication }, | ||||
|         { "/"sv, SQL::AST::BinaryOperator::Division }, | ||||
|         { "%"sv, SQL::AST::BinaryOperator::Modulo }, | ||||
|         { "+"sv, SQL::AST::BinaryOperator::Plus }, | ||||
|         { "-"sv, SQL::AST::BinaryOperator::Minus }, | ||||
|         { "<<"sv, SQL::AST::BinaryOperator::ShiftLeft }, | ||||
|         { ">>"sv, SQL::AST::BinaryOperator::ShiftRight }, | ||||
|         { "&"sv, SQL::AST::BinaryOperator::BitwiseAnd }, | ||||
|         { "|"sv, SQL::AST::BinaryOperator::BitwiseOr }, | ||||
|         { "<"sv, SQL::AST::BinaryOperator::LessThan }, | ||||
|         { "<="sv, SQL::AST::BinaryOperator::LessThanEquals }, | ||||
|         { ">"sv, SQL::AST::BinaryOperator::GreaterThan }, | ||||
|         { ">="sv, SQL::AST::BinaryOperator::GreaterThanEquals }, | ||||
|         { "="sv, SQL::AST::BinaryOperator::Equals }, | ||||
|         { "=="sv, SQL::AST::BinaryOperator::Equals }, | ||||
|         { "!="sv, SQL::AST::BinaryOperator::NotEquals }, | ||||
|         { "<>"sv, SQL::AST::BinaryOperator::NotEquals }, | ||||
|         { "AND"sv, SQL::AST::BinaryOperator::And }, | ||||
|         { "OR"sv, SQL::AST::BinaryOperator::Or }, | ||||
|     }; | ||||
| 
 | ||||
|     for (auto op : operators) { | ||||
|         EXPECT(parse(op.key).is_error()); | ||||
| 
 | ||||
|         StringBuilder builder; | ||||
|         builder.append("1 "); | ||||
|         builder.append("1 "sv); | ||||
|         builder.append(op.key); | ||||
|         EXPECT(parse(builder.build()).is_error()); | ||||
| 
 | ||||
|  | @ -225,7 +225,7 @@ TEST_CASE(binary_operator) | |||
| 
 | ||||
|         if (op.key != "+" && op.key != "-") { // "+1" and "-1" are fine (unary operator).
 | ||||
|             builder.append(op.key); | ||||
|             builder.append(" 1"); | ||||
|             builder.append(" 1"sv); | ||||
|             EXPECT(parse(builder.build()).is_error()); | ||||
|         } | ||||
|     } | ||||
|  | @ -245,18 +245,18 @@ TEST_CASE(binary_operator) | |||
| 
 | ||||
|     for (auto op : operators) { | ||||
|         StringBuilder builder; | ||||
|         builder.append("1 "); | ||||
|         builder.append("1 "sv); | ||||
|         builder.append(op.key); | ||||
|         builder.append(" 1"); | ||||
|         builder.append(" 1"sv); | ||||
|         validate(builder.build(), op.value); | ||||
|     } | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(chained_expression) | ||||
| { | ||||
|     EXPECT(parse("()").is_error()); | ||||
|     EXPECT(parse("(,)").is_error()); | ||||
|     EXPECT(parse("(15,)").is_error()); | ||||
|     EXPECT(parse("()"sv).is_error()); | ||||
|     EXPECT(parse("(,)"sv).is_error()); | ||||
|     EXPECT(parse("(15,)"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, size_t expected_chain_size) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -272,20 +272,20 @@ TEST_CASE(chained_expression) | |||
|             EXPECT(!is<SQL::AST::ErrorExpression>(chained_expression)); | ||||
|     }; | ||||
| 
 | ||||
|     validate("(15)", 1); | ||||
|     validate("(15, 16)", 2); | ||||
|     validate("(15, 16, column_name)", 3); | ||||
|     validate("(15)"sv, 1); | ||||
|     validate("(15, 16)"sv, 2); | ||||
|     validate("(15, 16, column_name)"sv, 3); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(cast_expression) | ||||
| { | ||||
|     EXPECT(parse("CAST").is_error()); | ||||
|     EXPECT(parse("CAST (").is_error()); | ||||
|     EXPECT(parse("CAST ()").is_error()); | ||||
|     EXPECT(parse("CAST (15)").is_error()); | ||||
|     EXPECT(parse("CAST (15 AS").is_error()); | ||||
|     EXPECT(parse("CAST (15 AS)").is_error()); | ||||
|     EXPECT(parse("CAST (15 AS int").is_error()); | ||||
|     EXPECT(parse("CAST"sv).is_error()); | ||||
|     EXPECT(parse("CAST ("sv).is_error()); | ||||
|     EXPECT(parse("CAST ()"sv).is_error()); | ||||
|     EXPECT(parse("CAST (15)"sv).is_error()); | ||||
|     EXPECT(parse("CAST (15 AS"sv).is_error()); | ||||
|     EXPECT(parse("CAST (15 AS)"sv).is_error()); | ||||
|     EXPECT(parse("CAST (15 AS int"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, StringView expected_type_name) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -303,25 +303,25 @@ TEST_CASE(cast_expression) | |||
|         EXPECT_EQ(type_name->name(), expected_type_name); | ||||
|     }; | ||||
| 
 | ||||
|     validate("CAST (15 AS int)", "INT"); | ||||
|     validate("CAST (15 AS int)"sv, "INT"sv); | ||||
|     // FIXME The syntax in the test below fails on both sqlite3 and psql (PostgreSQL).
 | ||||
|     // Also fails here because null is interpreted as the NULL keyword and not the
 | ||||
|     // identifier null (which is not a type)
 | ||||
|     // validate("CAST ('NULL' AS null)", "null");
 | ||||
|     validate("CAST (15 AS varchar(255))", "VARCHAR"); | ||||
|     // validate("CAST ('NULL' AS null)"sv, "null"sv);
 | ||||
|     validate("CAST (15 AS varchar(255))"sv, "VARCHAR"sv); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(case_expression) | ||||
| { | ||||
|     EXPECT(parse("CASE").is_error()); | ||||
|     EXPECT(parse("CASE END").is_error()); | ||||
|     EXPECT(parse("CASE 15").is_error()); | ||||
|     EXPECT(parse("CASE 15 END").is_error()); | ||||
|     EXPECT(parse("CASE WHEN").is_error()); | ||||
|     EXPECT(parse("CASE WHEN THEN").is_error()); | ||||
|     EXPECT(parse("CASE WHEN 15 THEN 16").is_error()); | ||||
|     EXPECT(parse("CASE WHEN 15 THEN 16 ELSE").is_error()); | ||||
|     EXPECT(parse("CASE WHEN 15 THEN 16 ELSE END").is_error()); | ||||
|     EXPECT(parse("CASE"sv).is_error()); | ||||
|     EXPECT(parse("CASE END"sv).is_error()); | ||||
|     EXPECT(parse("CASE 15"sv).is_error()); | ||||
|     EXPECT(parse("CASE 15 END"sv).is_error()); | ||||
|     EXPECT(parse("CASE WHEN"sv).is_error()); | ||||
|     EXPECT(parse("CASE WHEN THEN"sv).is_error()); | ||||
|     EXPECT(parse("CASE WHEN 15 THEN 16"sv).is_error()); | ||||
|     EXPECT(parse("CASE WHEN 15 THEN 16 ELSE"sv).is_error()); | ||||
|     EXPECT(parse("CASE WHEN 15 THEN 16 ELSE END"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, bool expect_case_expression, size_t expected_when_then_size, bool expect_else_expression) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -350,31 +350,31 @@ TEST_CASE(case_expression) | |||
|             EXPECT(!is<SQL::AST::ErrorExpression>(*else_expression)); | ||||
|     }; | ||||
| 
 | ||||
|     validate("CASE WHEN 16 THEN 17 END", false, 1, false); | ||||
|     validate("CASE WHEN 16 THEN 17 WHEN 18 THEN 19 END", false, 2, false); | ||||
|     validate("CASE WHEN 16 THEN 17 WHEN 18 THEN 19 ELSE 20 END", false, 2, true); | ||||
|     validate("CASE WHEN 16 THEN 17 END"sv, false, 1, false); | ||||
|     validate("CASE WHEN 16 THEN 17 WHEN 18 THEN 19 END"sv, false, 2, false); | ||||
|     validate("CASE WHEN 16 THEN 17 WHEN 18 THEN 19 ELSE 20 END"sv, false, 2, true); | ||||
| 
 | ||||
|     validate("CASE 15 WHEN 16 THEN 17 END", true, 1, false); | ||||
|     validate("CASE 15 WHEN 16 THEN 17 WHEN 18 THEN 19 END", true, 2, false); | ||||
|     validate("CASE 15 WHEN 16 THEN 17 WHEN 18 THEN 19 ELSE 20 END", true, 2, true); | ||||
|     validate("CASE 15 WHEN 16 THEN 17 END"sv, true, 1, false); | ||||
|     validate("CASE 15 WHEN 16 THEN 17 WHEN 18 THEN 19 END"sv, true, 2, false); | ||||
|     validate("CASE 15 WHEN 16 THEN 17 WHEN 18 THEN 19 ELSE 20 END"sv, true, 2, true); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(exists_expression) | ||||
| { | ||||
|     EXPECT(parse("EXISTS").is_error()); | ||||
|     EXPECT(parse("EXISTS (").is_error()); | ||||
|     EXPECT(parse("EXISTS (SELECT").is_error()); | ||||
|     EXPECT(parse("EXISTS (SELECT)").is_error()); | ||||
|     EXPECT(parse("EXISTS (SELECT * FROM table_name").is_error()); | ||||
|     EXPECT(parse("NOT EXISTS").is_error()); | ||||
|     EXPECT(parse("NOT EXISTS (").is_error()); | ||||
|     EXPECT(parse("NOT EXISTS (SELECT").is_error()); | ||||
|     EXPECT(parse("NOT EXISTS (SELECT)").is_error()); | ||||
|     EXPECT(parse("NOT EXISTS (SELECT * FROM table_name").is_error()); | ||||
|     EXPECT(parse("(").is_error()); | ||||
|     EXPECT(parse("(SELECT").is_error()); | ||||
|     EXPECT(parse("(SELECT)").is_error()); | ||||
|     EXPECT(parse("(SELECT * FROM table_name").is_error()); | ||||
|     EXPECT(parse("EXISTS"sv).is_error()); | ||||
|     EXPECT(parse("EXISTS ("sv).is_error()); | ||||
|     EXPECT(parse("EXISTS (SELECT"sv).is_error()); | ||||
|     EXPECT(parse("EXISTS (SELECT)"sv).is_error()); | ||||
|     EXPECT(parse("EXISTS (SELECT * FROM table_name"sv).is_error()); | ||||
|     EXPECT(parse("NOT EXISTS"sv).is_error()); | ||||
|     EXPECT(parse("NOT EXISTS ("sv).is_error()); | ||||
|     EXPECT(parse("NOT EXISTS (SELECT"sv).is_error()); | ||||
|     EXPECT(parse("NOT EXISTS (SELECT)"sv).is_error()); | ||||
|     EXPECT(parse("NOT EXISTS (SELECT * FROM table_name"sv).is_error()); | ||||
|     EXPECT(parse("("sv).is_error()); | ||||
|     EXPECT(parse("(SELECT"sv).is_error()); | ||||
|     EXPECT(parse("(SELECT)"sv).is_error()); | ||||
|     EXPECT(parse("(SELECT * FROM table_name"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, bool expected_invert_expression) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -387,16 +387,16 @@ TEST_CASE(exists_expression) | |||
|         EXPECT_EQ(exists.invert_expression(), expected_invert_expression); | ||||
|     }; | ||||
| 
 | ||||
|     validate("EXISTS (SELECT * FROM table_name)", false); | ||||
|     validate("NOT EXISTS (SELECT * FROM table_name)", true); | ||||
|     validate("(SELECT * FROM table_name)", false); | ||||
|     validate("EXISTS (SELECT * FROM table_name)"sv, false); | ||||
|     validate("NOT EXISTS (SELECT * FROM table_name)"sv, true); | ||||
|     validate("(SELECT * FROM table_name)"sv, false); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(collate_expression) | ||||
| { | ||||
|     EXPECT(parse("COLLATE").is_error()); | ||||
|     EXPECT(parse("COLLATE name").is_error()); | ||||
|     EXPECT(parse("15 COLLATE").is_error()); | ||||
|     EXPECT(parse("COLLATE"sv).is_error()); | ||||
|     EXPECT(parse("COLLATE name"sv).is_error()); | ||||
|     EXPECT(parse("15 COLLATE"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, StringView expected_collation_name) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -410,18 +410,18 @@ TEST_CASE(collate_expression) | |||
|         EXPECT_EQ(collate.collation_name(), expected_collation_name); | ||||
|     }; | ||||
| 
 | ||||
|     validate("15 COLLATE fifteen", "FIFTEEN"); | ||||
|     validate("(15, 16) COLLATE \"chain\"", "chain"); | ||||
|     validate("15 COLLATE fifteen"sv, "FIFTEEN"sv); | ||||
|     validate("(15, 16) COLLATE \"chain\""sv, "chain"sv); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(is_expression) | ||||
| { | ||||
|     EXPECT(parse("IS").is_error()); | ||||
|     EXPECT(parse("IS 1").is_error()); | ||||
|     EXPECT(parse("1 IS").is_error()); | ||||
|     EXPECT(parse("IS NOT").is_error()); | ||||
|     EXPECT(parse("IS NOT 1").is_error()); | ||||
|     EXPECT(parse("1 IS NOT").is_error()); | ||||
|     EXPECT(parse("IS"sv).is_error()); | ||||
|     EXPECT(parse("IS 1"sv).is_error()); | ||||
|     EXPECT(parse("1 IS"sv).is_error()); | ||||
|     EXPECT(parse("IS NOT"sv).is_error()); | ||||
|     EXPECT(parse("IS NOT 1"sv).is_error()); | ||||
|     EXPECT(parse("1 IS NOT"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, bool expected_invert_expression) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -436,30 +436,30 @@ TEST_CASE(is_expression) | |||
|         EXPECT_EQ(is_.invert_expression(), expected_invert_expression); | ||||
|     }; | ||||
| 
 | ||||
|     validate("1 IS NULL", false); | ||||
|     validate("1 IS NOT NULL", true); | ||||
|     validate("1 IS NULL"sv, false); | ||||
|     validate("1 IS NOT NULL"sv, true); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(match_expression) | ||||
| { | ||||
|     HashMap<StringView, SQL::AST::MatchOperator> operators { | ||||
|         { "LIKE", SQL::AST::MatchOperator::Like }, | ||||
|         { "GLOB", SQL::AST::MatchOperator::Glob }, | ||||
|         { "MATCH", SQL::AST::MatchOperator::Match }, | ||||
|         { "REGEXP", SQL::AST::MatchOperator::Regexp }, | ||||
|         { "LIKE"sv, SQL::AST::MatchOperator::Like }, | ||||
|         { "GLOB"sv, SQL::AST::MatchOperator::Glob }, | ||||
|         { "MATCH"sv, SQL::AST::MatchOperator::Match }, | ||||
|         { "REGEXP"sv, SQL::AST::MatchOperator::Regexp }, | ||||
|     }; | ||||
| 
 | ||||
|     for (auto op : operators) { | ||||
|         EXPECT(parse(op.key).is_error()); | ||||
| 
 | ||||
|         StringBuilder builder; | ||||
|         builder.append("1 "); | ||||
|         builder.append("1 "sv); | ||||
|         builder.append(op.key); | ||||
|         EXPECT(parse(builder.build()).is_error()); | ||||
| 
 | ||||
|         builder.clear(); | ||||
|         builder.append(op.key); | ||||
|         builder.append(" 1"); | ||||
|         builder.append(" 1"sv); | ||||
|         EXPECT(parse(builder.build()).is_error()); | ||||
|     } | ||||
| 
 | ||||
|  | @ -480,30 +480,30 @@ TEST_CASE(match_expression) | |||
| 
 | ||||
|     for (auto op : operators) { | ||||
|         StringBuilder builder; | ||||
|         builder.append("1 "); | ||||
|         builder.append("1 "sv); | ||||
|         builder.append(op.key); | ||||
|         builder.append(" 1"); | ||||
|         builder.append(" 1"sv); | ||||
|         validate(builder.build(), op.value, false, false); | ||||
| 
 | ||||
|         builder.clear(); | ||||
|         builder.append("1 NOT "); | ||||
|         builder.append("1 NOT "sv); | ||||
|         builder.append(op.key); | ||||
|         builder.append(" 1"); | ||||
|         builder.append(" 1"sv); | ||||
|         validate(builder.build(), op.value, true, false); | ||||
| 
 | ||||
|         builder.clear(); | ||||
|         builder.append("1 NOT "); | ||||
|         builder.append("1 NOT "sv); | ||||
|         builder.append(op.key); | ||||
|         builder.append(" 1 ESCAPE '+'"); | ||||
|         builder.append(" 1 ESCAPE '+'"sv); | ||||
|         validate(builder.build(), op.value, true, true); | ||||
|     } | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(null_expression) | ||||
| { | ||||
|     EXPECT(parse("ISNULL").is_error()); | ||||
|     EXPECT(parse("NOTNULL").is_error()); | ||||
|     EXPECT(parse("15 NOT").is_error()); | ||||
|     EXPECT(parse("ISNULL"sv).is_error()); | ||||
|     EXPECT(parse("NOTNULL"sv).is_error()); | ||||
|     EXPECT(parse("15 NOT"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, bool expected_invert_expression) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -516,21 +516,21 @@ TEST_CASE(null_expression) | |||
|         EXPECT_EQ(null.invert_expression(), expected_invert_expression); | ||||
|     }; | ||||
| 
 | ||||
|     validate("15 ISNULL", false); | ||||
|     validate("15 NOTNULL", true); | ||||
|     validate("15 NOT NULL", true); | ||||
|     validate("15 ISNULL"sv, false); | ||||
|     validate("15 NOTNULL"sv, true); | ||||
|     validate("15 NOT NULL"sv, true); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(between_expression) | ||||
| { | ||||
|     EXPECT(parse("BETWEEN").is_error()); | ||||
|     EXPECT(parse("NOT BETWEEN").is_error()); | ||||
|     EXPECT(parse("BETWEEN 10 AND 20").is_error()); | ||||
|     EXPECT(parse("NOT BETWEEN 10 AND 20").is_error()); | ||||
|     EXPECT(parse("15 BETWEEN 10").is_error()); | ||||
|     EXPECT(parse("15 BETWEEN 10 AND").is_error()); | ||||
|     EXPECT(parse("15 BETWEEN AND 20").is_error()); | ||||
|     EXPECT(parse("15 BETWEEN 10 OR 20").is_error()); | ||||
|     EXPECT(parse("BETWEEN"sv).is_error()); | ||||
|     EXPECT(parse("NOT BETWEEN"sv).is_error()); | ||||
|     EXPECT(parse("BETWEEN 10 AND 20"sv).is_error()); | ||||
|     EXPECT(parse("NOT BETWEEN 10 AND 20"sv).is_error()); | ||||
|     EXPECT(parse("15 BETWEEN 10"sv).is_error()); | ||||
|     EXPECT(parse("15 BETWEEN 10 AND"sv).is_error()); | ||||
|     EXPECT(parse("15 BETWEEN AND 20"sv).is_error()); | ||||
|     EXPECT(parse("15 BETWEEN 10 OR 20"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, bool expected_invert_expression) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -546,16 +546,16 @@ TEST_CASE(between_expression) | |||
|         EXPECT_EQ(between.invert_expression(), expected_invert_expression); | ||||
|     }; | ||||
| 
 | ||||
|     validate("15 BETWEEN 10 AND 20", false); | ||||
|     validate("15 NOT BETWEEN 10 AND 20", true); | ||||
|     validate("15 BETWEEN 10 AND 20"sv, false); | ||||
|     validate("15 NOT BETWEEN 10 AND 20"sv, true); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(in_table_expression) | ||||
| { | ||||
|     EXPECT(parse("IN").is_error()); | ||||
|     EXPECT(parse("IN table_name").is_error()); | ||||
|     EXPECT(parse("NOT IN").is_error()); | ||||
|     EXPECT(parse("NOT IN table_name").is_error()); | ||||
|     EXPECT(parse("IN"sv).is_error()); | ||||
|     EXPECT(parse("IN table_name"sv).is_error()); | ||||
|     EXPECT(parse("NOT IN"sv).is_error()); | ||||
|     EXPECT(parse("NOT IN table_name"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, StringView expected_schema, StringView expected_table, bool expected_invert_expression) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -571,17 +571,17 @@ TEST_CASE(in_table_expression) | |||
|         EXPECT_EQ(in.invert_expression(), expected_invert_expression); | ||||
|     }; | ||||
| 
 | ||||
|     validate("15 IN table_name", {}, "TABLE_NAME", false); | ||||
|     validate("15 IN schema_name.table_name", "SCHEMA_NAME", "TABLE_NAME", false); | ||||
|     validate("15 IN table_name"sv, {}, "TABLE_NAME"sv, false); | ||||
|     validate("15 IN schema_name.table_name"sv, "SCHEMA_NAME"sv, "TABLE_NAME"sv, false); | ||||
| 
 | ||||
|     validate("15 NOT IN table_name", {}, "TABLE_NAME", true); | ||||
|     validate("15 NOT IN schema_name.table_name", "SCHEMA_NAME", "TABLE_NAME", true); | ||||
|     validate("15 NOT IN table_name"sv, {}, "TABLE_NAME"sv, true); | ||||
|     validate("15 NOT IN schema_name.table_name"sv, "SCHEMA_NAME"sv, "TABLE_NAME"sv, true); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(in_chained_expression) | ||||
| { | ||||
|     EXPECT(parse("IN ()").is_error()); | ||||
|     EXPECT(parse("NOT IN ()").is_error()); | ||||
|     EXPECT(parse("IN ()"sv).is_error()); | ||||
|     EXPECT(parse("NOT IN ()"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, size_t expected_chain_size, bool expected_invert_expression) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -599,21 +599,21 @@ TEST_CASE(in_chained_expression) | |||
|             EXPECT(!is<SQL::AST::ErrorExpression>(chained_expression)); | ||||
|     }; | ||||
| 
 | ||||
|     validate("15 IN ()", 0, false); | ||||
|     validate("15 IN (15)", 1, false); | ||||
|     validate("15 IN (15, 16)", 2, false); | ||||
|     validate("15 IN ()"sv, 0, false); | ||||
|     validate("15 IN (15)"sv, 1, false); | ||||
|     validate("15 IN (15, 16)"sv, 2, false); | ||||
| 
 | ||||
|     validate("15 NOT IN ()", 0, true); | ||||
|     validate("15 NOT IN (15)", 1, true); | ||||
|     validate("15 NOT IN (15, 16)", 2, true); | ||||
|     validate("15 NOT IN ()"sv, 0, true); | ||||
|     validate("15 NOT IN (15)"sv, 1, true); | ||||
|     validate("15 NOT IN (15, 16)"sv, 2, true); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(in_selection_expression) | ||||
| { | ||||
|     EXPECT(parse("IN (SELECT)").is_error()); | ||||
|     EXPECT(parse("IN (SELECT * FROM table_name, SELECT * FROM table_name);").is_error()); | ||||
|     EXPECT(parse("NOT IN (SELECT)").is_error()); | ||||
|     EXPECT(parse("NOT IN (SELECT * FROM table_name, SELECT * FROM table_name);").is_error()); | ||||
|     EXPECT(parse("IN (SELECT)"sv).is_error()); | ||||
|     EXPECT(parse("IN (SELECT * FROM table_name, SELECT * FROM table_name);"sv).is_error()); | ||||
|     EXPECT(parse("NOT IN (SELECT)"sv).is_error()); | ||||
|     EXPECT(parse("NOT IN (SELECT * FROM table_name, SELECT * FROM table_name);"sv).is_error()); | ||||
| 
 | ||||
|     auto validate = [](StringView sql, bool expected_invert_expression) { | ||||
|         auto result = parse(sql); | ||||
|  | @ -627,8 +627,8 @@ TEST_CASE(in_selection_expression) | |||
|         EXPECT_EQ(in.invert_expression(), expected_invert_expression); | ||||
|     }; | ||||
| 
 | ||||
|     validate("15 IN (SELECT * FROM table_name)", false); | ||||
|     validate("15 NOT IN (SELECT * FROM table_name)", true); | ||||
|     validate("15 IN (SELECT * FROM table_name)"sv, false); | ||||
|     validate("15 NOT IN (SELECT * FROM table_name)"sv, true); | ||||
| } | ||||
| 
 | ||||
| TEST_CASE(expression_tree_depth_limit) | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 sin-ack
						sin-ack