mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 15:37:46 +00:00
Everywhere: Add sv suffix to strings relying on StringView(char const*)
Each of these strings would previously rely on StringView's char const* constructor overload, which would call __builtin_strlen on the string. Since we now have operator ""sv, we can replace these with much simpler versions. This opens the door to being able to remove StringView(char const*). No functional changes.
This commit is contained in:
parent
e5f09ea170
commit
3f3f45580a
762 changed files with 8315 additions and 8316 deletions
|
@ -208,7 +208,7 @@ ErrorOr<void> MainWidget::initialize_menubar(GUI::Window& window)
|
|||
{
|
||||
auto file_menu = TRY(window.try_add_menu("&File"));
|
||||
TRY(file_menu->try_add_action(GUI::CommonActions::make_open_action([&](auto&) {
|
||||
auto response = FileSystemAccessClient::Client::the().try_open_file(&window, "Select theme file", "/res/themes");
|
||||
auto response = FileSystemAccessClient::Client::the().try_open_file(&window, "Select theme file", "/res/themes"sv);
|
||||
if (response.is_error())
|
||||
return;
|
||||
load_from_file(*response.value());
|
||||
|
@ -304,7 +304,7 @@ ErrorOr<void> MainWidget::initialize_menubar(GUI::Window& window)
|
|||
TRY(accessibility_menu->try_add_action(achromatomaly_accessibility_action));
|
||||
|
||||
auto help_menu = TRY(window.try_add_menu("&Help"));
|
||||
TRY(help_menu->try_add_action(GUI::CommonActions::make_about_action("Theme Editor", GUI::Icon::default_icon("app-theme-editor"), &window)));
|
||||
TRY(help_menu->try_add_action(GUI::CommonActions::make_about_action("Theme Editor", GUI::Icon::default_icon("app-theme-editor"sv), &window)));
|
||||
|
||||
return {};
|
||||
}
|
||||
|
@ -604,7 +604,7 @@ void MainWidget::set_palette(Gfx::Palette palette)
|
|||
void MainWidget::show_path_picker_dialog(StringView property_display_name, GUI::TextBox& path_input, PathPickerTarget path_picker_target)
|
||||
{
|
||||
bool open_folder = path_picker_target == PathPickerTarget::Folder;
|
||||
auto window_title = String::formatted(open_folder ? "Select {} folder" : "Select {} file", property_display_name);
|
||||
auto window_title = String::formatted(open_folder ? "Select {} folder"sv : "Select {} file"sv, property_display_name);
|
||||
auto target_path = path_input.text();
|
||||
if (Core::File::exists(target_path)) {
|
||||
if (!Core::File::is_directory(target_path))
|
||||
|
|
|
@ -96,17 +96,17 @@ void PreviewWidget::update_preview_window_locations()
|
|||
|
||||
void PreviewWidget::paint_preview(GUI::PaintEvent&)
|
||||
{
|
||||
paint_window("Inactive window", m_inactive_window_rect, Gfx::WindowTheme::WindowState::Inactive, active_window_icon());
|
||||
paint_window("Active window", m_active_window_rect, Gfx::WindowTheme::WindowState::Active, inactive_window_icon());
|
||||
paint_window("Inactive window"sv, m_inactive_window_rect, Gfx::WindowTheme::WindowState::Inactive, active_window_icon());
|
||||
paint_window("Active window"sv, m_active_window_rect, Gfx::WindowTheme::WindowState::Active, inactive_window_icon());
|
||||
}
|
||||
|
||||
void PreviewWidget::paint_hightlight_window()
|
||||
{
|
||||
GUI::Painter painter(*this);
|
||||
paint_window("Highlight window", m_highlight_window_rect, Gfx::WindowTheme::WindowState::Highlighted, inactive_window_icon(), 1);
|
||||
paint_window("Highlight window"sv, m_highlight_window_rect, Gfx::WindowTheme::WindowState::Highlighted, inactive_window_icon(), 1);
|
||||
auto button_rect = Gfx::IntRect(0, 0, 80, 22).centered_within(m_highlight_window_rect);
|
||||
Gfx::StylePainter::paint_button(painter, button_rect, preview_palette(), Gfx::ButtonStyle::Normal, false, false, false, true, false, false);
|
||||
painter.draw_text(button_rect, ":^)", Gfx::TextAlignment::Center, preview_palette().color(foreground_role()), Gfx::TextElision::Right, Gfx::TextWrapping::DontWrap);
|
||||
painter.draw_text(button_rect, ":^)"sv, Gfx::TextAlignment::Center, preview_palette().color(foreground_role()), Gfx::TextElision::Right, Gfx::TextWrapping::DontWrap);
|
||||
}
|
||||
|
||||
void PreviewWidget::second_paint_event(GUI::PaintEvent&)
|
||||
|
@ -144,7 +144,7 @@ void PreviewWidget::drop_event(GUI::DropEvent& event)
|
|||
if (urls.is_empty())
|
||||
return;
|
||||
if (urls.size() > 1) {
|
||||
GUI::MessageBox::show(window(), "ThemeEditor can only open one file at a time!", "One at a time please!", GUI::MessageBox::Type::Error);
|
||||
GUI::MessageBox::show(window(), "ThemeEditor can only open one file at a time!"sv, "One at a time please!"sv, GUI::MessageBox::Type::Error);
|
||||
return;
|
||||
}
|
||||
|
||||
|
|
|
@ -51,7 +51,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
|
|||
TRY(Core::System::unveil("/res", "r"));
|
||||
TRY(Core::System::unveil(nullptr, nullptr));
|
||||
|
||||
auto app_icon = GUI::Icon::default_icon("app-theme-editor");
|
||||
auto app_icon = GUI::Icon::default_icon("app-theme-editor"sv);
|
||||
auto window = GUI::Window::construct();
|
||||
|
||||
auto main_widget = TRY(window->try_set_main_widget<ThemeEditor::MainWidget>());
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue