RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:07:44 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/DevTools/HackStudio/ProjectBuilder.cpp
View file

@ -34,7 +34,7 @@ ErrorOr<void> ProjectBuilder::build(StringView active_file)
if (active_file.is_null())
return Error::from_string_literal("no active file");
if (active_file.ends_with(".js")) {
if (active_file.ends_with(".js"sv)) {
TRY(m_terminal->run_command(String::formatted("js -A {}", active_file)));
return {};
}
@ -60,7 +60,7 @@ ErrorOr<void> ProjectBuilder::run(StringView active_file)
if (active_file.is_null())
return Error::from_string_literal("no active file");
if (active_file.ends_with(".js")) {
if (active_file.ends_with(".js"sv)) {
TRY(m_terminal->run_command(String::formatted("js {}", active_file)));
return {};
}
@ -129,7 +129,7 @@ ErrorOr<void> ProjectBuilder::initialize_build_directory()
}
}
auto cmake_file_path = LexicalPath::join(build_directory(), "CMakeLists.txt").string();
auto cmake_file_path = LexicalPath::join(build_directory(), "CMakeLists.txt"sv).string();
if (Core::File::exists(cmake_file_path))
MUST(Core::File::remove(cmake_file_path, Core::File::RecursionMode::Disallowed, false));
@ -148,7 +148,7 @@ Optional<String> ProjectBuilder::find_cmake_file_for(StringView file_path) const
{
auto directory = LexicalPath::dirname(file_path);
while (!directory.is_empty()) {
auto cmake_path = LexicalPath::join(m_project_root, directory, "CMakeLists.txt");
auto cmake_path = LexicalPath::join(m_project_root, directory, "CMakeLists.txt"sv);
if (Core::File::exists(cmake_path.string()))
return cmake_path.string();
directory = LexicalPath::dirname(directory);