RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibCore/EventLoop.cpp
View file

@ -217,7 +217,7 @@ public:
void handle_request(JsonObject const& request)
{
auto type = request.get("type").as_string_or({});
auto type = request.get("type"sv).as_string_or({});
if (type.is_null()) {
dbgln("RPC client sent request without type field");
@ -255,7 +255,7 @@ public:
}
if (type == "SetInspectedObject") {
auto address = request.get("address").to_number<FlatPtr>();
auto address = request.get("address"sv).to_number<FlatPtr>();
for (auto& object : Object::all_objects()) {
if ((FlatPtr)&object == address) {
if (auto inspected_object = m_inspected_object.strong_ref())
@ -269,10 +269,10 @@ public:
}
if (type == "SetProperty") {
auto address = request.get("address").to_number<FlatPtr>();
auto address = request.get("address"sv).to_number<FlatPtr>();
for (auto& object : Object::all_objects()) {
if ((FlatPtr)&object == address) {
bool success = object.set_property(request.get("name").to_string(), request.get("value"));
bool success = object.set_property(request.get("name"sv).to_string(), request.get("value"sv));
JsonObject response;
response.set("type", "SetProperty");
response.set("success", success);