RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:57:34 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibCpp/AST.cpp
View file

@ -85,7 +85,7 @@ String NamedType::to_string() const
if (is_auto())
name = "auto";
else
name = m_name.is_null() ? "" : m_name->full_name();
name = m_name.is_null() ? ""sv : m_name->full_name();
return String::formatted("{}{}", qualifiers_string, name);
}
@ -109,7 +109,7 @@ String Reference::to_string() const
if (m_kind == Kind::Lvalue)
builder.append("&");
else
builder.append("&&");
builder.append("&&"sv);
return builder.to_string();
}
@ -123,7 +123,7 @@ String FunctionType::to_string() const
if (first)
first = false;
else
builder.append(", ");
builder.append(", "sv);
if (parameter.type())
builder.append(parameter.type()->to_string());
if (parameter.name() && !parameter.full_name().is_empty()) {
@ -552,7 +552,7 @@ StringView Name::full_name() const
builder.appendff("{}::", scope.name());
}
}
m_full_name = String::formatted("{}{}", builder.to_string(), m_name.is_null() ? "" : m_name->name());
m_full_name = String::formatted("{}{}", builder.to_string(), m_name.is_null() ? ""sv : m_name->name());
return *m_full_name;
}