RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 08:07:44 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibCrypto/ASN1/ASN1.cpp
View file

@ -85,14 +85,14 @@ Optional<Core::DateTime> parse_utc_time(StringView time)
Optional<unsigned> seconds, offset_hours, offset_minutes;
[[maybe_unused]] bool negative_offset = false;
if (!lexer.next_is('Z')) {
if (!lexer.next_is(is_any_of("+-"))) {
if (!lexer.next_is(is_any_of("+-"sv))) {
seconds = lexer.consume(2).to_uint();
if (!seconds.has_value()) {
return {};
}
}
if (lexer.next_is(is_any_of("+-"))) {
if (lexer.next_is(is_any_of("+-"sv))) {
negative_offset = lexer.consume() == '-';
offset_hours = lexer.consume(2).to_uint();
offset_minutes = lexer.consume(2).to_uint();
@ -136,7 +136,7 @@ Optional<Core::DateTime> parse_generalized_time(StringView time)
if (lexer.consume_specific('Z'))
goto done_parsing;
if (!lexer.next_is(is_any_of("+-"))) {
if (!lexer.next_is(is_any_of("+-"sv))) {
minute = lexer.consume(2).to_uint();
if (!minute.has_value()) {
return {};
@ -145,7 +145,7 @@ Optional<Core::DateTime> parse_generalized_time(StringView time)
goto done_parsing;
}
if (!lexer.next_is(is_any_of("+-"))) {
if (!lexer.next_is(is_any_of("+-"sv))) {
seconds = lexer.consume(2).to_uint();
if (!seconds.has_value()) {
return {};
@ -163,7 +163,7 @@ Optional<Core::DateTime> parse_generalized_time(StringView time)
goto done_parsing;
}
if (lexer.next_is(is_any_of("+-"))) {
if (lexer.next_is(is_any_of("+-"sv))) {
negative_offset = lexer.consume() == '-';
offset_hours = lexer.consume(2).to_uint();
offset_minutes = lexer.consume(2).to_uint();

6
Userland/Libraries/LibCrypto/ASN1/DER.cpp
View file

@ -312,7 +312,7 @@ void pretty_print(Decoder& decoder, OutputStream& stream, int indent)
dbgln("Integer PrettyPrint error: {}", value.error());
return;
}
builder.append(" 0x");
builder.append(" 0x"sv);
for (auto ch : value.value())
builder.appendff("{:0>2x}", ch);
break;
@ -323,7 +323,7 @@ void pretty_print(Decoder& decoder, OutputStream& stream, int indent)
dbgln("BitString PrettyPrint error: {}", value.error());
return;
}
builder.append(" 0b");
builder.append(" 0b"sv);
for (size_t i = 0; i < value.value().size(); ++i)
builder.append(value.value().get(i) ? '1' : '0');
break;
@ -334,7 +334,7 @@ void pretty_print(Decoder& decoder, OutputStream& stream, int indent)
dbgln("OctetString PrettyPrint error: {}", value.error());
return;
}
builder.append(" 0x");
builder.append(" 0x"sv);
for (auto ch : value.value())
builder.appendff("{:0>2x}", ch);
break;

2
Userland/Libraries/LibCrypto/Authentication/HMAC.h
View file

@ -77,7 +77,7 @@ public:
String class_name() const
{
StringBuilder builder;
builder.append("HMAC-");
builder.append("HMAC-"sv);
builder.append(m_inner_hasher.class_name());
return builder.build();
}

2
Userland/Libraries/LibCrypto/BigInt/SignedBigInteger.cpp
View file

@ -339,6 +339,6 @@ bool SignedBigInteger::operator>=(SignedBigInteger const& other) const
ErrorOr<void> AK::Formatter<Crypto::SignedBigInteger>::format(FormatBuilder& fmtbuilder, Crypto::SignedBigInteger const& value)
{
if (value.is_negative())
TRY(fmtbuilder.put_string("-"));
TRY(fmtbuilder.put_string("-"sv));
return Formatter<Crypto::UnsignedBigInteger>::format(fmtbuilder, value.unsigned_value());
}

2
Userland/Libraries/LibCrypto/Cipher/Mode/CBC.h
View file

@ -34,7 +34,7 @@ public:
{
StringBuilder builder;
builder.append(this->cipher().class_name());
builder.append("_CBC");
builder.append("_CBC"sv);
return builder.build();
}
#endif

2
Userland/Libraries/LibCrypto/Cipher/Mode/CTR.h
View file

@ -109,7 +109,7 @@ public:
{
StringBuilder builder;
builder.append(this->cipher().class_name());
builder.append("_CTR");
builder.append("_CTR"sv);
return builder.build();
}
#endif

2
Userland/Libraries/LibCrypto/Cipher/Mode/GCM.h
View file

@ -49,7 +49,7 @@ public:
{
StringBuilder builder;
builder.append(this->cipher().class_name());
builder.append("_GCM");
builder.append("_GCM"sv);
return builder.build();
}
#endif

2
Userland/Libraries/LibCrypto/NumberTheory/ModularFunctions.cpp
View file

@ -218,7 +218,7 @@ bool is_probably_prime(UnsignedBigInteger const& p)
UnsignedBigInteger random_big_prime(size_t bits)
{
VERIFY(bits >= 33);
UnsignedBigInteger min = UnsignedBigInteger::from_base(10, "6074001000").shift_left(bits - 33);
UnsignedBigInteger min = UnsignedBigInteger::from_base(10, "6074001000"sv).shift_left(bits - 33);
UnsignedBigInteger max = UnsignedBigInteger { 1 }.shift_left(bits).minus(1);
for (;;) {
auto p = random_number(min, max);