RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:07:34 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibDebug/DebugInfo.cpp
View file

@ -135,9 +135,10 @@ Optional<DebugInfo::SourcePositionAndAddress> DebugInfo::get_address_from_source
if (!file_path.starts_with("/"))
file_path = String::formatted("/{}", file_path);
constexpr char SERENITY_LIBS_PREFIX[] = "/usr/src/serenity";
constexpr auto SERENITY_LIBS_PREFIX = "/usr/src/serenity"sv;
if (file.starts_with(SERENITY_LIBS_PREFIX)) {
file_path = file.substring(sizeof(SERENITY_LIBS_PREFIX), file.length() - sizeof(SERENITY_LIBS_PREFIX));
size_t file_prefix_offset = SERENITY_LIBS_PREFIX.length() + 1;
file_path = file.substring(file_prefix_offset, file.length() - file_prefix_offset);
file_path = String::formatted("../{}", file_path);
}

4
Userland/Libraries/LibDebug/DebugSession.cpp
View file

@ -445,7 +445,7 @@ void DebugSession::update_loaded_libs()
vm_entries.for_each([&](auto& entry) {
// TODO: check that region is executable
auto vm_name = entry.as_object().get("name").as_string();
auto vm_name = entry.as_object().get("name"sv).as_string();
auto object_path = get_path_to_object(vm_name);
if (!object_path.has_value())
@ -455,7 +455,7 @@ void DebugSession::update_loaded_libs()
if (Core::File::looks_like_shared_library(lib_name))
lib_name = LexicalPath::basename(object_path.value());
FlatPtr base_address = entry.as_object().get("address").to_addr();
FlatPtr base_address = entry.as_object().get("address"sv).to_addr();
if (auto it = m_loaded_libraries.find(lib_name); it != m_loaded_libraries.end()) {
// We expect the VM regions to be sorted by address.
VERIFY(base_address >= it->value->base_address);