RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 08:37:35 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibDesktop/AppFile.cpp
View file

@ -33,7 +33,7 @@ void AppFile::for_each(Function<void(NonnullRefPtr<AppFile>)> callback, StringVi
return;
while (di.has_next()) {
auto name = di.next_path();
if (!name.ends_with(".af"))
if (!name.ends_with(".af"sv))
continue;
auto path = String::formatted("{}/{}", directory, name);
auto af = AppFile::open(path);

3
Userland/Libraries/LibDesktop/AppFile.h
View file

@ -15,7 +15,8 @@ namespace Desktop {
class AppFile : public RefCounted<AppFile> {
public:
static constexpr char const* APP_FILES_DIRECTORY = "/res/apps";
static constexpr auto APP_FILES_DIRECTORY = "/res/apps"sv;
static NonnullRefPtr<AppFile> get_for_app(StringView app_name);
static NonnullRefPtr<AppFile> open(StringView path);
static void for_each(Function<void(NonnullRefPtr<AppFile>)>, StringView directory = APP_FILES_DIRECTORY);

6
Userland/Libraries/LibDesktop/Launcher.cpp
View file

@ -19,9 +19,9 @@ auto Launcher::Details::from_details_str(String const& details_str) -> NonnullRe
auto details = adopt_ref(*new Details);
auto json = JsonValue::from_string(details_str).release_value_but_fixme_should_propagate_errors();
auto const& obj = json.as_object();
details->executable = obj.get("executable").to_string();
details->name = obj.get("name").to_string();
if (auto type_value = obj.get_ptr("type")) {
details->executable = obj.get("executable"sv).to_string();
details->name = obj.get("name"sv).to_string();
if (auto type_value = obj.get_ptr("type"sv)) {
auto type_str = type_value->to_string();
if (type_str == "app")
details->launcher_type = LauncherType::Application;