RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:17:34 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibSymbolication/Symbolication.cpp
View file

@ -185,14 +185,14 @@ Vector<Symbol> symbolicate_thread(pid_t pid, pid_t tid, IncludeSourcePosition in
for (auto& region_value : json.value().as_array().values()) {
auto& region = region_value.as_object();
auto name = region.get("name").to_string();
auto address = region.get("address").to_addr();
auto size = region.get("size").to_addr();
auto name = region.get("name"sv).to_string();
auto address = region.get("address"sv).to_addr();
auto size = region.get("size"sv).to_addr();
String path;
if (name == "/usr/lib/Loader.so") {
path = name;
} else if (name.ends_with(": .text") || name.ends_with(": .rodata")) {
} else if (name.ends_with(": .text"sv) || name.ends_with(": .rodata"sv)) {
auto parts = name.split_view(':');
path = parts[0];
} else {