RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 00:07:35 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibTest/JavaScriptTestRunner.h
View file

@ -275,9 +275,9 @@ inline Vector<String> TestRunner::get_test_paths() const
{
Vector<String> paths;
iterate_directory_recursively(m_test_root, [&](String const& file_path) {
if (!file_path.ends_with(".js"))
if (!file_path.ends_with(".js"sv))
return;
if (!file_path.ends_with("test-common.js"))
if (!file_path.ends_with("test-common.js"sv))
paths.append(file_path);
});
quick_sort(paths);
@ -413,9 +413,9 @@ inline JSFileResult TestRunner::run_file_test(String const& test_path)
Test::Case test { test_name, Test::Result::Fail, "", 0 };
VERIFY(test_value.is_object());
VERIFY(test_value.as_object().has("result"));
VERIFY(test_value.as_object().has("result"sv));
auto result = test_value.as_object().get("result");
auto result = test_value.as_object().get("result"sv);
VERIFY(result.is_string());
auto result_string = result.as_string();
if (result_string == "pass") {
@ -425,8 +425,8 @@ inline JSFileResult TestRunner::run_file_test(String const& test_path)
test.result = Test::Result::Fail;
m_counts.tests_failed++;
suite.most_severe_test_result = Test::Result::Fail;
VERIFY(test_value.as_object().has("details"));
auto details = test_value.as_object().get("details");
VERIFY(test_value.as_object().has("details"sv));
auto details = test_value.as_object().get("details"sv);
VERIFY(result.is_string());
test.details = details.as_string();
} else {
@ -436,7 +436,7 @@ inline JSFileResult TestRunner::run_file_test(String const& test_path)
m_counts.tests_skipped++;
}
test.duration_us = test_value.as_object().get("duration").to_u64(0);
test.duration_us = test_value.as_object().get("duration"sv).to_u64(0);
suite.tests.append(test);
});

2
Userland/Libraries/LibTest/JavaScriptTestRunnerMain.cpp
View file

@ -141,7 +141,7 @@ int main(int argc, char** argv)
test_root = String { specified_test_root };
} else {
#ifdef __serenity__
test_root = LexicalPath::join("/home/anon/Tests", String::formatted("{}-tests", program_name.split_view('-').last())).string();
test_root = LexicalPath::join("/home/anon/Tests"sv, String::formatted("{}-tests", program_name.split_view('-').last())).string();
#else
char* serenity_source_dir = getenv("SERENITY_SOURCE_DIR");
if (!serenity_source_dir) {

8
Userland/Libraries/LibTest/TestRunner.h
View file

@ -248,16 +248,16 @@ inline void TestRunner::print_test_results_as_json() const
StringView result_name;
switch (case_.result) {
case Result::Pass:
result_name = "PASSED";
result_name = "PASSED"sv;
break;
case Result::Fail:
result_name = "FAILED";
result_name = "FAILED"sv;
break;
case Result::Skip:
result_name = "SKIPPED";
result_name = "SKIPPED"sv;
break;
case Result::Crashed:
result_name = "PROCESS_ERROR";
result_name = "PROCESS_ERROR"sv;
break;
}