RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 17:47:44 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Userland/Libraries/LibVT/Terminal.cpp
View file

@ -689,7 +689,7 @@ void Terminal::IL(Parameters params)
void Terminal::DA(Parameters)
{
emit_string("\033[?1;0c");
emit_string("\033[?1;0c"sv);
}
void Terminal::DL(Parameters params)
@ -959,7 +959,7 @@ void Terminal::DSR(Parameters params)
{
if (params.size() == 1 && params[0] == 5) {
// Device status
emit_string("\033[0n"); // Terminal status OK!
emit_string("\033[0n"sv); // Terminal status OK!
} else if (params.size() == 1 && params[0] == 6) {
// Cursor position query
StringBuilder builder;
@ -1388,7 +1388,7 @@ void Terminal::handle_key_press(KeyCode key, u32 code_point, u8 flags)
case KeyCode::Key_Return:
// The standard says that CR should be generated by the return key.
// The TTY will take care of translating it to CR LF for the terminal.
emit_string("\r");
emit_string("\r"sv);
return;
default:
break;
@ -1400,7 +1400,7 @@ void Terminal::handle_key_press(KeyCode key, u32 code_point, u8 flags)
}
if (shift && key == KeyCode::Key_Tab) {
emit_string("\033[Z");
emit_string("\033[Z"sv);
return;
}
@ -1416,7 +1416,7 @@ void Terminal::handle_key_press(KeyCode key, u32 code_point, u8 flags)
// Alt modifier sends escape prefix.
if (alt)
emit_string("\033");
emit_string("\033"sv);
StringBuilder sb;
sb.append_code_point(code_point);
@ -1433,7 +1433,7 @@ void Terminal::unimplemented_escape_sequence(Intermediates intermediates, u8 las
StringBuilder builder;
builder.appendff("Unimplemented escape sequence {:c}", last_byte);
if (!intermediates.is_empty()) {
builder.append(", intermediates: ");
builder.append(", intermediates: "sv);
for (size_t i = 0; i < intermediates.size(); ++i)
builder.append((char)intermediates[i]);
}
@ -1445,13 +1445,13 @@ void Terminal::unimplemented_csi_sequence(Parameters parameters, Intermediates i
StringBuilder builder;
builder.appendff("Unimplemented CSI sequence: {:c}", last_byte);
if (!parameters.is_empty()) {
builder.append(", parameters: [");
builder.append(", parameters: ["sv);
for (size_t i = 0; i < parameters.size(); ++i)
builder.appendff("{}{}", (i == 0) ? "" : ", ", parameters[i]);
builder.append("]");
}
if (!intermediates.is_empty()) {
builder.append(", intermediates:");
builder.append(", intermediates:"sv);
for (size_t i = 0; i < intermediates.size(); ++i)
builder.append((char)intermediates[i]);
}
@ -1465,15 +1465,15 @@ void Terminal::unimplemented_osc_sequence(OscParameters parameters, u8 last_byte
bool first = true;
for (auto parameter : parameters) {
if (!first)
builder.append(", ");
builder.append("[");
builder.append(", "sv);
builder.append('[');
for (auto character : parameter)
builder.append((char)character);
builder.append("]");
first = false;
}
builder.append(" ]");
builder.append(" ]"sv);
dbgln("{}", builder.string_view());
}