RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:37:47 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWasm/AbstractMachine/Validator.h
View file

@ -200,11 +200,11 @@ public:
ErrorOr<void, ValidationError> take(ValueType type, SourceLocation location = SourceLocation::current())
{
if (is_empty())
return Errors::invalid("stack state", type, "<nothing>", location);
return Errors::invalid("stack state"sv, type, "<nothing>"sv, location);
auto type_on_stack = take_last();
if (type_on_stack != type)
return Errors::invalid("stack state", type, type_on_stack, location);
return Errors::invalid("stack state"sv, type, type_on_stack, location);
return {};
}
@ -287,13 +287,13 @@ private:
else
builder.appendff("Invalid stack state in <unknown>: ");
builder.append("Expected [ ");
builder.append("Expected [ "sv);
expected.apply_as_args([&]<typename... Ts>(Ts const&... args) {
(builder.appendff("{} ", args), ...);
});
builder.append("], but found [ ");
builder.append("], but found [ "sv);
auto actual_size = stack.actual_size();
for (size_t i = 1; i <= min(count, actual_size); ++i) {