RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Services/LookupServer/LookupServer.cpp
View file

@ -95,7 +95,7 @@ void LookupServer::load_etc_hosts()
if (original_line.is_empty())
break;
auto trimmed_line = original_line.view().trim_whitespace();
auto replaced_line = trimmed_line.replace(" ", "\t", ReplaceMode::All);
auto replaced_line = trimmed_line.replace(" "sv, "\t"sv, ReplaceMode::All);
auto fields = replaced_line.split_view('\t', false);
if (fields.size() < 2) {
@ -119,7 +119,7 @@ void LookupServer::load_etc_hosts()
StringBuilder builder;
builder.append(maybe_address->to_string_reversed());
builder.append(".in-addr.arpa");
builder.append(".in-addr.arpa"sv);
add_answer(builder.to_string(), RecordType::PTR, name.as_string());
}
}
@ -182,7 +182,7 @@ ErrorOr<Vector<Answer>> LookupServer::lookup(Name const& name, RecordType record
}
// Fourth, look up .local names using mDNS instead of DNS nameservers.
if (name.as_string().ends_with(".local")) {
if (name.as_string().ends_with(".local"sv)) {
answers = m_mdns->lookup(name, record_type);
for (auto& answer : answers)
put_in_cache(answer);