RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 11:37:45 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/TelnetServer/Client.cpp
View file

@ -170,10 +170,10 @@ ErrorOr<void> Client::send_data(StringView data)
switch (c) {
case '\n':
builder.append("\r\n");
builder.append("\r\n"sv);
break;
case IAC:
builder.append("\xff\xff");
builder.append("\xff\xff"sv);
break;
default:
builder.append(c);

14
Userland/Services/TelnetServer/Command.h
View file

@ -27,30 +27,30 @@ struct Command {
switch (command) {
case CMD_WILL:
builder.append("WILL");
builder.append("WILL"sv);
break;
case CMD_WONT:
builder.append("WONT");
builder.append("WONT"sv);
break;
case CMD_DO:
builder.append("DO");
builder.append("DO"sv);
break;
case CMD_DONT:
builder.append("DONT");
builder.append("DONT"sv);
break;
default:
builder.append(String::formatted("UNKNOWN<{:02x}>", command));
break;
}
builder.append(" ");
builder.append(" "sv);
switch (subcommand) {
case SUB_ECHO:
builder.append("ECHO");
builder.append("ECHO"sv);
break;
case SUB_SUPPRESS_GO_AHEAD:
builder.append("SUPPRESS_GO_AHEAD");
builder.append("SUPPRESS_GO_AHEAD"sv);
break;
default:
builder.append(String::formatted("UNKNOWN<{:02x}>", subcommand));

4
Userland/Services/TelnetServer/Parser.cpp
View file

@ -22,7 +22,7 @@ void Parser::write(StringView data)
break;
case '\r':
if (on_data)
on_data("\n");
on_data("\n"sv);
break;
case '\0':
case '\n':
@ -39,7 +39,7 @@ void Parser::write(StringView data)
case IAC: {
m_state = State::Free;
if (on_data)
on_data("\xff");
on_data("\xff"sv);
break;
}
case CMD_WILL: