RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:07:35 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Shell/Builtin.cpp
View file

@ -213,7 +213,7 @@ int Shell::builtin_type(int argc, char const** argv)
if (!(i == fn.arguments.size() - 1))
builder.append(" ");
}
builder.append(") {\n");
builder.append(") {\n"sv);
if (fn.body) {
auto formatter = Formatter(*fn.body);
builder.append(formatter.format());
@ -831,7 +831,7 @@ int Shell::builtin_shift(int argc, char const** argv)
if (count < 1)
return 0;
auto argv_ = lookup_local_variable("ARGV");
auto argv_ = lookup_local_variable("ARGV"sv);
if (!argv_) {
warnln("shift: ARGV is unset");
return 1;
@ -864,7 +864,7 @@ int Shell::builtin_source(int argc, char const** argv)
if (!parser.parse(argc, const_cast<char**>(argv)))
return 1;
auto previous_argv = lookup_local_variable("ARGV");
auto previous_argv = lookup_local_variable("ARGV"sv);
ScopeGuard guard { [&] {
if (!args.is_empty())
set_local_variable("ARGV", move(previous_argv));