RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:17:45 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Utilities/asctl.cpp
View file

@ -45,7 +45,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
TRY(Core::System::unveil(nullptr, nullptr));
TRY(Core::System::pledge("stdio rpath wpath recvfd thread"));
if (command.equals_ignoring_case("get") || command == "g") {
if (command.equals_ignoring_case("get"sv) || command == "g") {
// Get variables
Vector<AudioVariable> values_to_print;
if (command_arguments.is_empty()) {
@ -97,7 +97,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
}
if (!human_mode)
outln();
} else if (command.equals_ignoring_case("set") || command == "s") {
} else if (command.equals_ignoring_case("set"sv) || command == "s") {
// Set variables
HashMap<AudioVariable, Variant<int, bool>> values_to_set;
for (size_t i = 0; i < command_arguments.size(); ++i) {
@ -120,9 +120,9 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
} else if (variable.is_one_of("m"sv, "mute"sv)) {
auto& mute_text = command_arguments[++i];
bool mute;
if (mute_text.equals_ignoring_case("true") || mute_text == "1") {
if (mute_text.equals_ignoring_case("true"sv) || mute_text == "1") {
mute = true;
} else if (mute_text.equals_ignoring_case("false") || mute_text == "0") {
} else if (mute_text.equals_ignoring_case("false"sv) || mute_text == "0") {
mute = false;
} else {
warnln("Error: {} is not one of {{0, 1, true, false}}", mute_text);