RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 10:47:35 +00:00
Code Issues Activity Actions

Everywhere: Add sv suffix to strings relying on StringView(char const*)

Browse source 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
This commit is contained in:
sin-ack 2022-07-11 17:32:29 +00:00 • committed by Andreas Kling
parent e5f09ea170
commit 3f3f45580a
762 changed files with 8315 additions and 8316 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Utilities/mktemp.cpp
View file

@ -13,7 +13,7 @@
#include <sys/stat.h>
#include <unistd.h>
constexpr StringView default_template = "tmp.XXXXXXXXXX";
constexpr StringView default_template = "tmp.XXXXXXXXXX"sv;
static String generate_random_filename(String const& pattern)
{
@ -87,7 +87,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
file_template = default_template;
}
if (!file_template.find("XXX").has_value()) {
if (!file_template.find("XXX"sv).has_value()) {
if (!quiet)
warnln("Too few X's in template {}", file_template);
return 1;